feat: add github action to self-assign the issue - #3774
Conversation
Astro-Han
left a comment
There was a problem hiding this comment.
I reviewed this head and found blocking issues.
[P2] Actor-wide concurrency will drop pending commands
take.yml:30-31 groups only by github.actor without queue, so a second take from the same user on another issue cancels the pending job for the first issue. Commands are silently dropped. Must isolate by issue and use queue: max.
[P2] Mutation HTTP failures still show green
take.yml:47,54 POST/DELETE curl lacks --fail and status checks; any 403/404/422/5xx still exits 0 and the workflow remains green while assignee state is unchanged. Add failure handling and verification.
Standards hard: PR template says behavior=No but the workflow does change behavior (issue assignees), and verification is empty yet marked as passed — needs correction.
Checks on 6a0cf5557 are no checks — gate not met.
简体中文
存在并发与 HTTP 失败两项阻断及模板问题。CLOSES apache#3773 Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
6a0cf55 to
12f52a3
Compare
Done |
Astro-Han
left a comment
There was a problem hiding this comment.
I reviewed this head and found no blocking issues.
The workflow now correctly isolates concurrency per issue with queue: max and handles HTTP failures with --fail and assignee verification. No injection, minimal permissions, and checklist now honest.
Checks on 12f52a3113 have no required test (workflow-only change) — gate is not applicable.
Summary
Add a github action to enable self-assignment.
Fixes #3773
Verification
AI use
Select exactly one:
Tool(s) and scope:
Checklist
Does this PR entail a change in behavior?