Skip to content

feat: add github action to self-assign the issue - #3774

Open
Phoenix500526 wants to merge 1 commit into
apache:mainfrom
Phoenix500526:feat/self-assign-issue
Open

feat: add github action to self-assign the issue#3774
Phoenix500526 wants to merge 1 commit into
apache:mainfrom
Phoenix500526:feat/self-assign-issue

Conversation

@Phoenix500526

Copy link
Copy Markdown

Summary

Add a github action to enable self-assignment.

Fixes #3773

Verification

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this head and found blocking issues.

[P2] Actor-wide concurrency will drop pending commands

take.yml:30-31 groups only by github.actor without queue, so a second take from the same user on another issue cancels the pending job for the first issue. Commands are silently dropped. Must isolate by issue and use queue: max.

[P2] Mutation HTTP failures still show green

take.yml:47,54 POST/DELETE curl lacks --fail and status checks; any 403/404/422/5xx still exits 0 and the workflow remains green while assignee state is unchanged. Add failure handling and verification.

Standards hard: PR template says behavior=No but the workflow does change behavior (issue assignees), and verification is empty yet marked as passed — needs correction.

Checks on 6a0cf5557 are no checks — gate not met.

简体中文存在并发与 HTTP 失败两项阻断及模板问题。

CLOSES apache#3773

Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
@Phoenix500526
Phoenix500526 force-pushed the feat/self-assign-issue branch from 6a0cf55 to 12f52a3 Compare August 25, 2026 09:07
@Phoenix500526

Copy link
Copy Markdown
Author

I reviewed this head and found blocking issues.

[P2] Actor-wide concurrency will drop pending commands

take.yml:30-31 groups only by github.actor without queue, so a second take from the same user on another issue cancels the pending job for the first issue. Commands are silently dropped. Must isolate by issue and use queue: max.

[P2] Mutation HTTP failures still show green

take.yml:47,54 POST/DELETE curl lacks --fail and status checks; any 403/404/422/5xx still exits 0 and the workflow remains green while assignee state is unchanged. Add failure handling and verification.

Standards hard: PR template says behavior=No but the workflow does change behavior (issue assignees), and verification is empty yet marked as passed — needs correction.

Checks on 6a0cf5557 are no checks — gate not met.

简体中文
存在并发与 HTTP 失败两项阻断及模板问题。

Done

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this head and found no blocking issues.

The workflow now correctly isolates concurrency per issue with queue: max and handles HTTP failures with --fail and assignee verification. No injection, minimal permissions, and checklist now honest.

Checks on 12f52a3113 have no required test (workflow-only change) — gate is not applicable.

简体中文该头未发现阻断。

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — 12f52a3, no P0-P2, concurrency and HTTP handling fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add a github action to self-assign the issue

2 participants