Skip to content

refactor(runtime-host): share verified deployment identity - #3766

Merged
Astro-Han merged 1 commit into
apache:mainfrom
me2seeks:feat/runtime-host-deployment-identity
Aug 25, 2026
Merged

refactor(runtime-host): share verified deployment identity#3766
Astro-Han merged 1 commit into
apache:mainfrom
me2seeks:feat/runtime-host-deployment-identity

Conversation

@me2seeks

@me2seeks me2seeks commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Define the exact Runtime Host deployment identity that Maka can currently verify: an npm registry version plus SHA-512 integrity.
  • Make registry update candidates carry that shared identity from discovery through package acquisition.
  • Revalidate the complete identity at the package boundary while keeping the existing service-management wire frame unchanged.

This is the first, behavior-preserving layer of the local deployment-owner work. It deliberately adds no owner record, transfer authority, Desktop evidence format, remote deployment authority, or lifecycle behavior.

Refs #3231
Design context: #3709

中文摘要
  • 定义 Maka 当前能够验证的精确 Runtime Host 部署身份:npm registry 版本号与 SHA-512 integrity。
  • 让 registry 更新候选从发现到包获取都携带同一份共享身份。
  • 在包边界重新验证完整身份,同时保持现有 service-management wire frame 不变。

这是本地部署 owner 工作的第一层、行为不变的基础 PR。它不新增 owner 记录、转移权限、Desktop 证据格式、remote 部署权限或生命周期行为。

Verification

  • npm --workspace @maka/runtime-host run build
  • npm --workspace maka-agent run build
  • Focused Runtime Host update tests: 17 passed.
  • Full CLI suite: 450 passed.
  • Scoped Biome lint and git diff --check passed.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex helped design and implement the shared deployment-identity contract, propagation, validation, and tests under user direction. The affected commit includes a Generated-by: Codex trailer.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this head. No Spec blocking issues, but hard Standards breaches block approval.

[P3] Standards — missing commit trailer and incomplete PR template

  • Commit 286bf417 with AI-assisted changes lacks required Generated-by: Codex trailer (per CONTRIBUTING.md:30-34).
  • PR body does not include the template's AI-use selection/scope, checklist, or behavior yes/no (per :79-81). Needs completed template.

Spec is GO — identity {version, integrity} correctly modeled and verified through discovery/selection/acquisition, with SHA-512 re-hash and compatibility separate.

Checks on 286bf41710 are test: success, but standards gate is not met.

简体中文存在提交信息与模板两项标准不合规。

@me2seeks
me2seeks force-pushed the feat/runtime-host-deployment-identity branch from 286bf41 to 21f195d Compare August 25, 2026 07:09
@me2seeks

Copy link
Copy Markdown
Contributor Author

Addressed the standards findings on new exact head 21f195d82:

The old and new tree objects are identical for all three rewritten commits; this update changes attribution/history only, not source or test content. CI is running again on each new head.

简体中文

已在新 head 21f195d82 修复两项标准问题:commit 补充 Generated-by: Codex trailer,PR body 恢复完整 AI-use、checklist 与 behavior 选择。依赖的 #3767/#3769 已按顺序 rebase;同时主动修复了 #3767 的相同标准问题。三个 commit 改写前后的 tree 完全一致,只改变 attribution/history,不改变源码或测试内容;CI 正在重新运行。

Generated-by: Codex

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this head and found no blocking issues.

The deployment identity is now cleanly modeled as {kind, version, integrity} with verification at discovery, selection, and package acquisition — correctly distinguishing same-version-different-content artifacts. No new authority, state, or lifecycle is added.

No P0-P3.

简体中文该头未发现阻断。

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — 21f195d, no P0-P3, identity correctly scoped.

@Astro-Han
Astro-Han merged commit ef71012 into apache:main Aug 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants