Skip to content

test(desktop): scope slash menu refresh observer - #3739

Closed
liuxiaocs7 wants to merge 1 commit into
apache:mainfrom
liuxiaocs7:fix/slash-command-menu-refresh-flake
Closed

test(desktop): scope slash menu refresh observer#3739
liuxiaocs7 wants to merge 1 commit into
apache:mainfrom
liuxiaocs7:fix/slash-command-menu-refresh-flake

Conversation

@liuxiaocs7

Copy link
Copy Markdown
Member

Summary

Scope the slash-command menu refresh regression watcher to the open menu and the original listbox and Skills group nodes. Wait for each session's real invocable-skills projection request before checking that those nodes remain connected, avoiding unrelated overlay removals and fixed timing delays.

Fixes #3727

Verification

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex implemented the test synchronization and observer scoping changes, added the E2E-only preload signal, and assisted with verification.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

Limit the regression watcher to the open slash popover and the three projection refresh calls. Wait on each session Skill projection request before asserting that the original listbox and Skills group remain connected.

Fixes apache#3727

Generated-by: OpenAI Codex
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks for the thorough fix! We chose to merge #3737 for this issue — it achieves the same correction (narrowing the observer to close the over-broad window) with zero production surface (1 file, no preload changes), which is minimal for a test-only flake. Your approach with a deterministic waitForInvocableSkillsCall is causally stronger, but we preferred to avoid expanding the preload test seam for this flake. Appreciate the effort — closing as superseded by #3737.

@Astro-Han Astro-Han closed this Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: slash-command-menu "keeps its container and skills group across projection refreshes"

2 participants