test(desktop): scope slash menu refresh observer - #3739
Closed
liuxiaocs7 wants to merge 1 commit into
Closed
Conversation
Limit the regression watcher to the open slash popover and the three projection refresh calls. Wait on each session Skill projection request before asserting that the original listbox and Skills group remain connected. Fixes apache#3727 Generated-by: OpenAI Codex
Contributor
|
Thanks for the thorough fix! We chose to merge #3737 for this issue — it achieves the same correction (narrowing the observer to close the over-broad window) with zero production surface (1 file, no preload changes), which is minimal for a test-only flake. Your approach with a deterministic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope the slash-command menu refresh regression watcher to the open menu and the original listbox and Skills group nodes. Wait for each session's real invocable-skills projection request before checking that those nodes remain connected, avoiding unrelated overlay removals and fixed timing delays.
Fixes #3727
Verification
AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex implemented the test synchronization and observer scoping changes, added the E2E-only preload signal, and assisted with verification.
Checklist
Does this PR entail a change in behavior?