Skip to content

Add multi-SKIP case to gfi-sweep - #1153

Closed
harshit01-creator wants to merge 1 commit into
apache:mainfrom
harshit01-creator:fix/issue-1001-multi-skip
Closed

Add multi-SKIP case to gfi-sweep#1153
harshit01-creator wants to merge 1 commit into
apache:mainfrom
harshit01-creator:fix/issue-1001-multi-skip

Conversation

@harshit01-creator

@harshit01-creator harshit01-creator commented Sep 6, 2026

Copy link
Copy Markdown

Summary

Type of change

  • Skill change (.claude/skills/<name>/) — eval fixtures updated below
  • Tool / bridge contract (tools/<system>/*.md)
  • Python package (tools/*/ with pyproject.toml)
  • Groovy reference impl
  • Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
  • Documentation (docs/, README.md, CONTRIBUTING.md)
  • Project template (projects/_template/)
  • CI / dev loop (prek, workflows, validators)
  • Other:

Test plan

  • prek run --all-files passes
  • For Python packages touched: uv run pytest / ruff check / mypy passes
  • For Groovy bridges touched: command-line invocation tested end-to-end
  • For skill changes: eval suite passes for the affected skill
    (PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)
  • For skill behaviour changes: a new or updated eval fixture is included in this PR
    (a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
  • Other:

RFC-AI-0004 compliance

  • HITL — any new mutation is gated on explicit user confirmation
  • Sandbox — no new unrestricted host access; network reach declared in the adapter
  • Vendor neutrality — placeholders (<PROJECT>, <tracker>, <upstream>, <security-list>) used in all skill / tool prose (the check-placeholders prek hook is the mechanical gate)
  • Conversational + correctable — agentic-override path documented if behaviour is adopter-tunable
  • Write-access discipline — no autonomous outbound messages; drafts only, sent on confirmation
  • Privacy LLM — private content does not reach a non-approved LLM; redactor invoked where needed

Linked issues

Notes for reviewers (optional)

@onlyarnav onlyarnav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is nothing in description of the PR that explain anything what you did.
refer to contribution rules on how to open a pull request

@potiuk
potiuk force-pushed the fix/issue-1001-multi-skip branch from 3b44ff6 to 1688c34 Compare September 7, 2026 22:52
@potiuk potiuk closed this Sep 7, 2026
@potiuk

potiuk commented Sep 7, 2026

Copy link
Copy Markdown
Member

Indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants