Keep Check port label from leaving stale blocking checks - #4324
Closed
ramanathan1504 wants to merge 1 commit into
Closed
ramanathan1504 wants to merge 1 commit into
ramanathan1504 wants to merge 1 commit into
Conversation
ramanathan1504
added
appenders:Flume
port-to-main
port-to-2.25.x
port-to-2.26.x
and removed
appenders:Flume
labels
Contributor
Author
|
Closed becasued already label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every run of
Check port labelleaves its own check on the head commit, and a cancelled or failed one keeps the PR blocked even after a re-run passes.#4303 shows this. On
2575885:Re-running the old run cannot recover it, since a re-run replays the original event payload, which carried no labels.