[SECURITY] Remove public documentation of auth bypass in Knife4jConfig#5459
Merged
casionone merged 1 commit intoJul 16, 2026
Merged
Conversation
… from Knife4jConfig The Knife4jConfig scaladoc literally instructed readers to set dataworkcloud_inner_request=true (plus a forged ticket value) in their browser cookies to access protected API docs. This constituted public documentation of the bypass mechanism. This commit removes the bypass instructions and the unsafe wds.linkis.test.mode suggestion. Replaces them with a safe wds.linkis.server.user.restful.uri.pass.auth whitelist approach and a security notice. Reported-by: Strick Sheng, Liyi Zhou, Ziyue, Maurice, Chenchen #AI COMMIT#
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Knife4jConfig scaladoc comment explicitly instructed readers to set
dataworkcloud_inner_request=true(plus a forged ticket value) in their browser cookies to access protected API docs. This constituted public documentation of the bypass mechanism.Changes
dataworkcloud_inner_request=truecookiewds.linkis.test.mode=truesuggestionAffected files
linkis-commons/linkis-module/.../Knife4jConfig.scala(+7/-7, comment-only)Deployment impact
None — documentation-only change.
🤖 Generated with Claude Code