[SECURITY] Enforce server-side session map check in ignore-timeout fallback path#5458
Merged
casionone merged 1 commit intoJul 16, 2026
Conversation
aiceflower
force-pushed
the
fix-enforce-session-map-check-in-fallback
branch
from
July 16, 2026 03:37
6ae0961 to
03f9933
Compare
…e-timeout fallback - getLoginUserIgnoreTimeout: normal users now go through isTimeoutOrNot (session map lookup) - OTHER_SYSTEM_IGNORE_UM_USER remains exempt (internal RPC, not browser-cookie-based) - Add escape hatch: linkis.security.ignore.timeout.require.session.map=false restores legacy behavior - Add CommonVars import for config toggle
aiceflower
force-pushed
the
fix-enforce-session-map-check-in-fallback
branch
from
July 16, 2026 03:53
03f9933 to
3931400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getLoginUserIgnoreTimeoutpreviously skippedisTimeoutOrNotentirely — any ticket that decrypted cleanly (with the known default key) was accepted even if it was never registered viasetLoginUser. This was the second half of the auth bypass.This PR adds
isTimeoutOrNotfor all normal users even in the ignore-timeout path. The only exception isOTHER_SYSTEM_IGNORE_UM_USER(internal RPC identity via header).Changes
SSOUtils.getLoginUserIgnoreTimeout: normal users now go throughisTimeoutOrNot(session map lookup)OTHER_SYSTEM_IGNORE_UM_USERremains exempt (internal RPC, not browser-cookie-based)Affected files
linkis-commons/linkis-module/.../SSOUtils.scala(+20/-1)Deployment impact
🤖 Generated with Claude Code