Conversation
chia7712
reviewed
Sep 12, 2026
| throw new NumberFormatException(about + ": failed to " + | ||
| "parse number: " + e.getMessage()); | ||
| } | ||
| if (!node.isIntegralNumber() || !node.canConvertToLong()) { |
Member
There was a problem hiding this comment.
Interesting. It was not dead code. Rather, it is a kind of fallback for parsing "long" type. @Russole Would you mind updating the PR description?
Contributor
Author
There was a problem hiding this comment.
You're right. It was a fallback for other integral node types. I'll update the description.
Russole
changed the title
Russole
changed the title
chia7712
reviewed
Sep 13, 2026
| throw new NumberFormatException(about + ": failed to " + | ||
| "parse number: " + e.getMessage()); | ||
| } | ||
| if (!node.isIntegralNumber() || !node.canConvertToInt()) { |
Member
There was a problem hiding this comment.
It seems to me they should use different error messages, making the output more readable. WDYT?
Contributor
Author
There was a problem hiding this comment.
Good point. I’ve updated them to use separate messages for invalid types and out-of-range values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies
MessageUtil.jsonNodeToIntandjsonNodeToLong. Theexisting code converts compatible numeric nodes to strings and parses
them back as a fallback. The new implementation keeps this behavior by
validating the integral value and its range before returning
intValue()orlongValue()directly. Tests cover supported integralnodes, out-of-range values, and invalid node types.
Testing
./gradlew clients:test --tests org.apache.kafka.common.protocol.MessageUtilTestReviewers: Chia-Ping Tsai chia7712@gmail.com