KAFKA-10561: Preserve sub-millisecond precision in TimestampConverter - #23432
Open
michal-swiatowy wants to merge 1 commit into
Open
michal-swiatowy wants to merge 1 commit into
michal-swiatowy wants to merge 1 commit into
Conversation
Replace java.util.Date (millisecond precision) with java.time.Instant (nanosecond precision) as the internal intermediate representation in TimestampConverter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: I used https://issues.apache.org/jira/browse/KAFKA-10561 for my PR but not sure how much it matches, I'm happy to change or create a new issue if required. Maybe https://issues.apache.org/jira/browse/KAFKA-10627?
Main idea
Replace
java.util.Date(millisecond precision) withjava.time.Instant(nanosecond precision) as the internal representation inTimestampConverter. This fixes loss of microsecond and nanosecond data when converting between unix and string timestamp formats.To do this a new
format.typeconfiguration option is added that selects the string parsing/formatting engine:java.time.format.DateTimeFormatterKey invariants
format.typeTesting
Sample usage