Skip to content

MINOR: Rename computeSinkRecordLag to computeSinkRecordActiveCount - #23431

Open
mapan1984 wants to merge 1 commit into
apache:trunkfrom
mapan1984:rename-sink-record-active-count
Open

MINOR: Rename computeSinkRecordLag to computeSinkRecordActiveCount#23431
mapan1984 wants to merge 1 commit into
apache:trunkfrom
mapan1984:rename-sink-record-active-count

Conversation

@mapan1984

Copy link
Copy Markdown
Contributor

computeSinkRecordLag computes consumedOffset - committedOffset, which is the value backing the sink-record-active-count metric, not an actual fetch lag.

@github-actions github-actions Bot added triage PRs from the community connect small Small PRs labels Sep 11, 2026
@mapan1984

Copy link
Copy Markdown
Contributor Author

PR #3975 renamed this metric from sink-record-lag-max to sink-record-active-count, since the underlying value (consumedOffset - committedOffset) isn't a real fetch lag. The backing method name was never updated to match.

Fixing it avoids confusion with the sink-record-lag-max metric (true fetch lag). That metric is currently documented but never implemented; I plan to add the implementation in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connect small Small PRs triage PRs from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant