KAFKA-21064 Apache RAT Gradle plugin version upgrade; redundant custom style file is removed

[dejan2609]

Jira ticket: KAFKA-21064

details:

• Apache RAT Gradle plugin version upgrade: 0.8.1 --> 0.11.0
• redundant custom style file is removed

release notes:

• Apache RAT Gradle plugin: https://github.com/eskatos/creadur-rat-gradle/blob/v0.11.0/CHANGELOG.md
• Apache RAT (bundled version is upgraded form 0.15 to 0.18):
  • 0.18: https://github.com/apache/creadur-rat/blob/apache-rat-project-0.18/RELEASE_NOTES.txt#L1
  • 0.17: https://github.com/apache/creadur-rat/blob/apache-rat-project-0.18/RELEASE_NOTES.txt#L86
  • 0.16.1: https://github.com/apache/creadur-rat/blob/apache-rat-project-0.18/RELEASE_NOTES.txt#L375
  • 0.16: https://github.com/apache/creadur-rat/blob/apache-rat-project-0.18/RELEASE_NOTES.txt#L414

[dejan2609]

Rationale for custom style file gradle/resources/rat-output-to-html.xsl removal: this style is equivalent to a default style.

Steps to verify this claim (use Kafka trunk branch):

• comment out file reference: build.gradle:stylesheet.set(file('gradle/resources/rat-output-to-html.xsl'))
• execute: ./gradlew rat
• compare two styles: diff build/tmp/rat/default-stylesheet.xsl gradle/resources/rat-output-to-html.xsl

69a70,71
>   <p>This HTML version (yes, it is!) is generated from the RAT xml reports using Saxon9B. All the outputs required are displayed below, similar to the .txt version.
>            This is obviously a work in progress; and a prettier, easier to read and manage version will be available soon</p>

[dejan2609]

Old report vs. new report:

[dejan2609]

Update: plugin version 0.10.0 takes additional time to build:

Kafka trunk (plugin version 0.8.1): ~ 40 seconds
PR mentioned above (plugin version 0.10.0): ~ 1minute and 40 seconds

so I created plugin-related issue (see above).

Plugin developer was extra responsive: root cause for this additional time is Apache RAT upgrade (0.15 --> 0.17) so he was kind enough to release a new plugin version 0.11.0 that's using Apache RAT 0.18.

All-in-all: I'll bump plugin version to 0.11.0

[dejan2609]

Update: ./gradlew rat --rerun-tasks --no-daemon task execution duration (with recent plugin versions) on my laptop:

• Kafka trunk, plugin version: 0.8.1 (RAT: 0.15) --> ~ 42s
• plugin version: 0.10.0 (RAT: 0.17) --> ~ 2m 5s
• plugin version: 0.11.0 (RAT: 0.18) --> ~ 1m 20s

[dejan2609]

Demoting to a draft (additional configuration is required).