KAFKA-21054: Fix vacuous timeout tests in InternalTopicManagerTest - #23417
Open
kuoche1712003 wants to merge 1 commit into
Open
kuoche1712003 wants to merge 1 commit into
kuoche1712003 wants to merge 1 commit into
Conversation
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two shouldThrowTimeoutException...HasTopicDescriptionTimeout tests
wrapped the call under test in try/catch without fail(), so they passed
whether or not an exception was thrown. Since KAFKA-14128 the code under
test swallows the TimeoutException from describeTopics and never throws,
so the catch block and its assertion have never executed.
Rename both tests to shouldNotThrowExceptionIf... and replace the
try/catch with assertDoesNotThrow so they fail if the behavior regresses
to throwing. Also collapse the duplicated identical call in the
getNumPartitions test, which was introduced by a rebase conflict
resolution in PR #13161.
Testing: test-only change. Ran InternalTopicManagerTest locally, all passing.
No production code is affected.