Skip to content

[Storage] Make three TierManager fields thread-safe for SonarCloud's reliability gate - #19228

Open
chrisdutz wants to merge 2 commits into
masterfrom
fix/tier-manager-thread-safe-fields
Open

[Storage] Make three TierManager fields thread-safe for SonarCloud's reliability gate#19228
chrisdutz wants to merge 2 commits into
masterfrom
fix/tier-manager-thread-safe-fields

[Storage] Test that the tier disk total space follows the tiers and i…

39f8a7b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 11, 2026 in 4m 37s

Quality Gate passed

Issues
67 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 67 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/disk/TierManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Single-line Javadoc comment should be multi-line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnF546Gx163_JXpj3&open=AaHKnF546Gx163_JXpj3&pullRequest=19228

Check warning on line 136 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/tree/SubscriptionTreePushConsumerBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'useSSL' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnKHj6Gx163_JXpki&open=AaHKnKHj6Gx163_JXpki&pullRequest=19228

Check warning on line 178 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsOfOneDeviceStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnGsH6Gx163_JXpkC&open=AaHKnGsH6Gx163_JXpkC&pullRequest=19228

Check warning on line 38 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/internal/session/InternalTableSessionPoolBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'}' at column 45 should be alone on a line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnFF-6Gx163_JXpjq&open=AaHKnFF-6Gx163_JXpjq&pullRequest=19228

Check warning on line 203 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnGpA6Gx163_JXpj_&open=AaHKnGpA6Gx163_JXpj_&pullRequest=19228

Check warning on line 165 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/DatabasePartitionTable.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '131'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnJfp6Gx163_JXpkU&open=AaHKnJfp6Gx163_JXpkU&pullRequest=19228

Check failure on line 561 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/receiver/SubscriptionReceiverV1.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnImd6Gx163_JXpkP&open=AaHKnImd6Gx163_JXpkP&pullRequest=19228

Check warning on line 764 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/PartitionInfo.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '728'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnJjC6Gx163_JXpkV&open=AaHKnJjC6Gx163_JXpkV&pullRequest=19228

Check warning on line 162 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertMultiTabletsStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnGlz6Gx163_JXpj9&open=AaHKnGlz6Gx163_JXpj9&pullRequest=19228

Check warning on line 52 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/InternalClientRPCServiceProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'InternalClientRPCServiceProcessor' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnHxN6Gx163_JXpkI&open=AaHKnHxN6Gx163_JXpkI&pullRequest=19228

Check warning on line 97 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/SimpleQueryTerminator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '87'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnGi16Gx163_JXpj6&open=AaHKnGi16Gx163_JXpj6&pullRequest=19228

Check warning on line 197 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/PipeMetaSyncer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 122). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnJGZ6Gx163_JXpkR&open=AaHKnJGZ6Gx163_JXpkR&pullRequest=19228

Check failure on line 99 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/disk/TierManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnF546Gx163_JXpj1&open=AaHKnF546Gx163_JXpj1&pullRequest=19228

Check warning on line 169 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsOfOneDeviceStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnGsH6Gx163_JXpkB&open=AaHKnGsH6Gx163_JXpkB&pullRequest=19228

Check warning on line 210 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnGpA6Gx163_JXpkA&open=AaHKnGpA6Gx163_JXpkA&pullRequest=19228

Check warning on line 65 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/SubscriptionTreeSessionBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'useSSL' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnKKs6Gx163_JXpkm&open=AaHKnKKs6Gx163_JXpkm&pullRequest=19228

Check warning on line 78 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/partition/RegionGroup.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Summary javadoc is missing. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnJl76Gx163_JXpkW&open=AaHKnJl76Gx163_JXpkW&pullRequest=19228

Check warning on line 28 in iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcServiceConstants.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'}' at column 34 should be alone on a line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnJ1O6Gx163_JXpkZ&open=AaHKnJ1O6Gx163_JXpkZ&pullRequest=19228

Check warning on line 66 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/SubscriptionTableSessionBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'useSSL' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnKKW6Gx163_JXpkj&open=AaHKnKKW6Gx163_JXpkj&pullRequest=19228

Check warning on line 82 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/disk/FolderManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'DiskSpaceInsufficientException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnFMu6Gx163_JXpjv&open=AaHKnFMu6Gx163_JXpjv&pullRequest=19228

Check warning on line 636 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/receiver/SubscriptionReceiverV1.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 153). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnImd6Gx163_JXpkQ&open=AaHKnImd6Gx163_JXpkQ&pullRequest=19228

Check warning on line 58 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionConsumerBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'useSSL' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnKB16Gx163_JXpkd&open=AaHKnKB16Gx163_JXpkd&pullRequest=19228

Check warning on line 255 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/LoadTsFileTableSchemaCache.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof IoTDBException iotdbexception' 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnHMG6Gx163_JXpkG&open=AaHKnHMG6Gx163_JXpkG&pullRequest=19228

Check warning on line 127 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/splitter/BatchedAlignedValueChunkData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnFwR6Gx163_JXpj0&open=AaHKnFwR6Gx163_JXpj0&pullRequest=19228

Check warning on line 959 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusSubscriptionCommitManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

WhitespaceAround: '{' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3) 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHKnIi96Gx163_JXpkN&open=AaHKnIi96Gx163_JXpkN&pullRequest=19228
View more details on SonarQubeCloud