Repository navigation
Fix relational insert tablet redirect row count - #19221
Merged
Merged
Conversation
JackieTien97
approved these changes
Nov 11, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19221 +/- ##
============================================
- Coverage 48.89% 48.89% -0.01%
Complexity 689 689
============================================
Files 5588 5588
Lines 413407 413407
Branches 54526 54526
============================================
- Hits 202120 202116 -4
- Misses 211287 211291 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
rowCountwhen constructing table-model redirect endpoints.Problem
Tabletbacking arrays may contain more slots than the number of valid rows represented byrowCount.RelationalInsertTabletNode.splitByReplicaSet()iterated overtimes.length, while device IDs are computed forrowCountrows. This could process rows outside the valid range and throwArrayIndexOutOfBoundsExceptionduring write planning.Fix
Build the redirect node list using
rowCount, matching the rows that are actually part of the tablet.Example
Before: a relational tablet with
rowCount = 2and four timestamp slots could fail withArrayIndexOutOfBoundsExceptionduring redirect construction.After: only the two valid rows produce redirect entries and planning completes normally.
Validation
./mvnw spotless:apply -pl iotdb-core/datanode.