Repository navigation
[1.3] Fix JDBC test cleanup and Pipe metadata request timeouts - #19193
Merged
Merged
Conversation
* Stub rejected submissions before registering pipe subtasks * Fix JDBC resource cleanup in non-query test utilities * Stabilize pipe operation diagnostics IT barriers (cherry picked from commit c5f57e9)
Caideyipi
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport the applicable changes from #19160 (c5f57e9) onto
dev/1.3at 8f589d4, and fix the metadata RPC deadline race exposed by the Pipe diagnostics tests.Non-query test helpers close statements and internally created connections on success and failure while preserving caller-owned connections. The Pipe diagnostics tests wait for the asynchronous leader-change procedure and its coordinator lock before issuing DROP, and verify that DROP creates a new connection attempt.
Single-pipe metadata RPCs now temporarily use the configured metadata request timeout. Previously, their default DataNode RPC timeout matched the procedure wait timeout: DROP could return a timeout and immediately finish in the background, removing the pipe before the concurrent-operation or restart-recovery assertions. The pooled client restores its original timeout when returned. The existing diagnostic, PRE_DELETE, concurrent-operation, recovery, and eventual-deletion assertions are unchanged.
Compatibility adaptations:
dev/1.3retry helper, which already uses try-with-resources. Adapt its cleanup regression scenarios to the existing four-argument API; there is no borrowed-connection retry overload on this branch.dev/1.3leader-change log marker and retain the tree-model test categories.Validation
IoTDBPipeOperationDiagnosticsITpassed on JDK 17 withwith-integration-tests,ClusterIT: 2 tests, 0 failures, 0 errors, 0 skips.