Repository navigation
[To dev/1.3] Fix batch partial insert failure reporting - #19187
Merged
Merged
Conversation
* Fix batch partial insert failure reporting * Fix IT * Preserve batch insert failures when invalid rows are removed * Localize batch partial insert failure reporting (cherry picked from commit db0a9b4)
Collaborator
Author
|
Initial self-review of Validation passed:
All new tests were run locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of
db0a9b4d756cc2558ca466895590ee58427c2c6cadapts batch partial-insert reporting to the 1.3 analyzer.Batch insert statements now aggregate failed measurements, exceptions, and messages from their child statements. Row batches retain failures recorded before invalid rows are filtered, and failure messages are deduplicated by measurement/message pair.
The 1.3 branch performs insert validation in
AnalyzeVisitor, so the reporting logic is adapted there from the source branch'sAnalyzeUtils.Validation:
InsertStatementPartialInsertTest, 15 tests passed.test-compilepassed for English andwith-zh-locale.