Skip to content

[To dev/1.3] Fix batch partial insert failure reporting - #19187

Merged
Caideyipi merged 1 commit into
apache:dev/1.3from
Caideyipi:codex/cp-db0a9b4
Nov 9, 2026
Merged

Caideyipi merged 1 commit into
apache:dev/1.3from
Caideyipi:codex/cp-db0a9b4

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Cherry-pick of db0a9b4d756cc2558ca466895590ee58427c2c6c adapts batch partial-insert reporting to the 1.3 analyzer.

Batch insert statements now aggregate failed measurements, exceptions, and messages from their child statements. Row batches retain failures recorded before invalid rows are filtered, and failure messages are deduplicated by measurement/message pair.

The 1.3 branch performs insert validation in AnalyzeVisitor, so the reporting logic is adapted there from the source branch's AnalyzeUtils.

Validation:

  • DataNode Spotless passed.
  • Clean DataNode test run: InsertStatementPartialInsertTest, 15 tests passed.
  • Full-reactor test-compile passed for English and with-zh-locale.

* Fix batch partial insert failure reporting

* Fix IT

* Preserve batch insert failures when invalid rows are removed

* Localize batch partial insert failure reporting

(cherry picked from commit db0a9b4)
@Caideyipi

Copy link
Copy Markdown
Collaborator Author

Initial self-review of 265fbb23f1769b7062bea52d4f7ac2f293d7186c found no remaining issues. The target diff carries the batch failure aggregation and reporting changes from db0a9b4d756cc2558ca466895590ee58427c2c6c, adapted to the existing 1.3 AnalyzeVisitor validation path.

Validation passed:

  • DataNode Spotless.
  • Full-reactor English and Chinese test-compile.
  • InsertStatementPartialInsertTest: 15 tests, 0 failures, 0 errors.

All new tests were run locally.

@Caideyipi
Caideyipi merged commit 256a206 into apache:dev/1.3 Nov 9, 2026
16 checks passed
@Caideyipi
Caideyipi deleted the codex/cp-db0a9b4 branch November 9, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant