Skip to content

[to dev/1.3] Fix TVList iterator state across memtable page switches - #18652

Merged
JackieTien97 merged 4 commits into
dev/1.3from
cp/18647-dev1.3
Sep 16, 2026
Merged

JackieTien97 merged 4 commits into
dev/1.3from
cp/18647-dev1.3

Conversation

@shuwenwei

@shuwenwei shuwenwei commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Backport

Cherry-pick of master PR #18647 to dev/1.3.

Changes

  • Preserve a prepared aligned duplicate-timestamp group when a fake-page switch does not move the iterator cursor.
  • Clear probeNext after non-aligned batch reads so a later point read cannot consume stale prepared state.
  • Add aligned ASC/DESC regression tests.
  • Add non-aligned ASC duplicate and DESC deletion batch-to-point regression tests.

dev/1.3 API Adaptation

  • The dev/1.3 TVList.iterator API takes seven arguments and does not take QueryContext; the non-aligned tests were adapted accordingly.
  • The dev/1.3 AlignedReadOnlyMemChunk constructor takes five arguments and does not include timeColumnDeletion; the aligned tests were adapted accordingly.

Validation

Static API/signature check only. No Maven build, formatting, or test command was run for this backport, as requested.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.12%. Comparing base (60fd1e2) to head (32e5db6).

Additional details and impacted files
@@            Coverage Diff             @@
##             dev/1.3   #18652   +/-   ##
==========================================
  Coverage      45.12%   45.12%           
  Complexity       198      198           
==========================================
  Files           3665     3665           
  Lines         250777   250778    +1     
  Branches       31036    31036           
==========================================
+ Hits          113161   113172   +11     
+ Misses        137616   137606   -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackieTien97
JackieTien97 merged commit aa0e230 into dev/1.3 Sep 16, 2026
19 checks passed
@JackieTien97
JackieTien97 deleted the cp/18647-dev1.3 branch September 16, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants