Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport the applicable compression-test fix from #18644 (
2838c35317ff4c0fda0eaec78b141d08d6ee34d0) todev/1.3.IoTDBPipeSinkCompressionITissued six rapid writes to the same time series withnow()timestamps. Because timestamps have millisecond precision, multiple writes can receive the same timestamp and be deduplicated, leaving the final row count below eight. This change uses deterministic timestamps 3 through 8 instead.The upstream commit also updates
IoTDBShowReceiversIT. That test and itsSHOW RECEIVERSfeature are not present ondev/1.3, so that part is intentionally omitted. The compression test also lives under the olderautocreatepackage on this branch; the conflict was resolved at that path.Verification
mvn spotless:check -pl integration-test -P with-integration-tests: passed.git diff origin/dev/1.3..HEAD --check: passed.IoTDBPipeSinkCompressionIT#testCompression1was attempted locally, but the integration-test module is currently blocked before execution by unrelated existing cross-module dependency errors (missingRepairDataPartitionTableProgressState, Jackson/Gson, and OPC UA classes). The corresponding targeted test passed in [Pipe] Stabilize receiver and compression integration tests #18644.This PR has:
Key changed/added classes
IoTDBPipeSinkCompressionIT