Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Table subscriptions can select databases, tables, and output columns, but they cannot filter individual rows by TAG value. This PR adds the
tag-filtertopic attribute for table-model subscriptions. Its default value istrue, so existing topics keep their current behavior.Filter semantics
AND,OR,NOT,=,!=,IN,LIKE,regexp_like, andIS NULL, evaluated with SQL three-valued logic.column-filterprojection.Delivery paths and configuration changes
Validation
TopicConfigTest: 10 tests passed.SubscriptionConsumerMultiProviderPollTest: 3 tests passed.git diff --check origin/master...HEAD: passed after rebasing onto currentorigin/master.This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
org.apache.iotdb.db.subscription.tagfilterSubscriptionFilterSnapshotSubscriptionTreeViewProjectorSubscriptionBrokerAgentConsensusLogToTabletConverterPipeTabletEventTsFileBatchTopicConfigandTopicMeta