Fix downgraded TsFileResource serialization#18155
Open
jt2594838 wants to merge 2 commits into
Open
Conversation
ef0d353 to
6400947
Compare
HTHou
approved these changes
Jul 8, 2026
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18155 +/- ##
============================================
+ Coverage 41.77% 41.89% +0.12%
Complexity 318 318
============================================
Files 5297 5297
Lines 374233 374235 +2
Branches 48314 48313 -1
============================================
+ Hits 156334 156790 +456
+ Misses 217899 217445 -454 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR fixes TsFileResource serialization when the in-memory TimeIndex has been degraded to FileTimeIndex.
When a resource file already exists, serialization now preserves the device-level time index stored in the resource file instead of serializing the degraded in-memory FileTimeIndex directly.
Tests
Follow-up
After rebasing to the latest master and reverting FileTimeIndex serialization, a local rerun of TsFileResourceTest was blocked by unrelated datanode compile errors in pipe classes.