Repository navigation
Conversation
New primitive types should not silently become identity sources, and the expressions spec must use the same source-type lists as the table spec. Generated-by: Cursor (Grok 4.7)
github-actions
Bot
added
the
Specification
Contributor
Author
|
if we don't agree with identity transform change (exclusion list -> inclusion list), we should at least update the bucket transform in the expression spec (exclusion list) to align with the table spec (inclusion list) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identity in the table spec accepts any primitive except geometry and geography, so a newly added primitive becomes a valid identity source without an explicit decision. Bucket in that table is already an allowlist. The expressions spec still describes both transforms with exception lists, and its bucket rule is broader than the table spec. This lists the source types explicitly in both specs and makes the expressions spec use the table spec's bucket allowlist.
Follow-up to the discussion on #18416 (comment)
Made with Cursor