Parquet: Extract nested/variant type check in ParquetMetricsRowGroupFilter - #17377
Open
uros-b wants to merge 2 commits into
Open
Parquet: Extract nested/variant type check in ParquetMetricsRowGroupFilter#17377uros-b wants to merge 2 commits into
uros-b wants to merge 2 commits into
Conversation
Co-authored-by: Isaac
uros-b
commented
Jul 26, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
CI failure doesn't look related to these code changes
Member
Author
|
@huaxingao please review Parquet changes |
Member
Author
Issue fixed in #17382, merging latest main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same nested-or-variant type check was duplicated verbatim across
notNull(),eq(), andin()inParquetMetricsRowGroupFilter. This extracts it into a privateisNestedOrVariantType(int id)helper (placed alongside the existingmin/maxhelpers) to remove the duplication. Behavior-preserving; the three call sites were byte-identical.