chore(deps): remove dead datafusion-ffi, unused workspace deps, and stale audit ignores - #3149
Open
kevinjqliu wants to merge 1 commit into
Open
chore(deps): remove dead datafusion-ffi, unused workspace deps, and stale audit ignores#3149kevinjqliu wants to merge 1 commit into
kevinjqliu wants to merge 1 commit into
Conversation
…tale audit ignores Follow-up cleanup after the DataFusion TableProvider removal (#3143). - Remove `datafusion-ffi` from workspace deps; nothing inherits it since the Python binding no longer exports a TableProvider. - Remove `aes` and `thrift` workspace deps; no crate inherits them (encryption uses the AES types re-exported by `aes-gcm`). - Drop audit ignores whose advisory no longer matches any locked crate: RUSTSEC-2024-0014 (generational-arena, gone with datafusion-ffi), RUSTSEC-2024-0388 (derivative), RUSTSEC-2025-0134 (rustls-pemfile), RUSTSEC-2026-0097 (rand, all locked versions patched), RUSTSEC-2026-0176/0177 (pyo3, lock is on 0.29.1). - Drop the unmatched MPL-2.0 license exception for generational-arena. Cargo.lock is unchanged. Verified with `cargo check --workspace --all-targets --all-features`, `cargo audit`, and `cargo deny check licenses`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Cleans up workspace dependency and policy configuration after the DataFusion TableProvider removal by removing unused workspace deps and stale security/license exceptions.
Changes:
- Removed unused workspace dependencies (
datafusion-ffi,aes,thrift) fromCargo.toml. - Dropped stale
cargo-auditignore entries that no longer match any locked crates. - Removed an unmatched MPL-2.0 license exception for
generational-arenafromdeny.toml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Cargo.toml |
Removes unused workspace dependencies to reduce maintenance and confusion. |
.cargo/audit.toml |
Removes ignore entries for advisories that no longer apply to the lockfile. |
deny.toml |
Drops a license exception for a crate no longer present. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None. Follow-up cleanup after the DataFusion
TableProviderremoval in #3143.What changes are included in this PR?
While looking for DataFusion-related cleanup after #3143 I found
datafusion-ffiwas still declared in the workspace with no consumer. Checking the rest of the workspace turned up a few more entries in the same state.datafusion-ffifrom[workspace.dependencies]; nothing inherits it.aesandthriftworkspace deps; no crate inherits them (thriftis not even inCargo.lock)..cargo/audit.tomlwhose advisory no longer matches any locked crate:generational-arena, only pulled in viadatafusion-ffi)derivative, not in lock)rustls-pemfile, not in lock)rand, all locked versions are patched)pyo3, lock is on 0.29.1)generational-arenaindeny.toml.Cargo.lockis unchanged.Are these changes tested?
cargo check --workspace --all-targets --all-featurespasses.cargo audit(fresh advisory DB) passes with no vulnerabilities.cargo deny check licensespasses.🤖 Generated with Claude Code