feat(writer): apply per-column parquet bloom filter write properties - #3148
Open
alessandro-nori wants to merge 2 commits into
Open
feat(writer): apply per-column parquet bloom filter write properties#3148alessandro-nori wants to merge 2 commits into
alessandro-nori wants to merge 2 commits into
Conversation
alessandro-nori
force-pushed
the
anori/parquet-bloom-filter-write-properties
branch
4 times, most recently
from
September 4, 2026 14:16
fc1c3d1 to
8033af8
Compare
alessandro-nori
force-pushed
the
anori/parquet-bloom-filter-write-properties
branch
from
September 4, 2026 14:33
8033af8 to
9bc3cf9
Compare
alessandro-nori
marked this pull request as ready for review
September 4, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
write.parquet.bloom-filter-*table properties #3147.What changes are included in this PR?
The Parquet writer ignored
write.parquet.bloom-filter-enabled.column.*,-fpp.column.*and-ndv.column.*, so a table configured for bloom filters silently got files without them.TableProperties: three prefixed-map properties for the per-column bloom settings.ParquetWriterBuilder::from_table_properties: applies them to the parquet-rs writer properties. Column names resolve to Parquet leaf paths through the existingIndexByParquetPathNamevisitor, so list elements and map keys work (tags.element→tags.list.element).DataInvalid.Tables already carrying these properties will start producing bloom filters.
Differences from Iceberg Java:
bloom-filter-max-bytesandbloom-filter-adaptive-enabledhave no parquet-rs equivalent and are not implemented.0.01even with no-fpp.column.set: parquet-rs defaults to0.05, parquet-mr to0.01.-enabled.column.isfalse, since both setters implicitly re-enable the filter.TableProperties.Are these changes tested?
Unit tests cover enable/disable, fpp/ndv application, nested struct columns, list elements and map keys, unknown and non-leaf columns, and both validation errors. An end-to-end test writes a file and reads the filter back, asserting a written value probes positive, an absent one negative, and an unconfigured column carries no filter.
AI Disclosure
Developed with AI assistance (Claude Code) for implementation, tests and review. I have reviewed and verified the change and take responsibility for its content.