fix(scan): validate deletion vector delete tasks - #3145
Open
linhongyu510 wants to merge 9 commits into
Open
Conversation
Author
|
CI follow-up pushed in 8ff9d12: removed the internal design note that failed the Apache license-header check, made the helper private, and updated the validated builder public API baseline. Verified locally with 15 targeted scan tests, rustfmt, clippy -D warnings, LICENSE/NOTICE checks, and cargo-public-api 0.51.0 output comparison. |
blackmwk
reviewed
Sep 4, 2026
| field_defaults(setter(prefix = "with_")), | ||
| build_method(into = Result<FileScanTaskDeleteFile>) | ||
| )] | ||
| pub struct FileScanTaskDeleteFile { |
Contributor
There was a problem hiding this comment.
We should remove all pub fields, and add pub getter to avoid inconsistent changes.
Author
|
Addressed the review in 0228cd4: all |
linhongyu510
marked this pull request as ready for review
September 4, 2026 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileScanTaskDeleteFileis builtTesting
cargo test -p iceberg scan::task::tests::test_delete_file_builder --libcargo test -p iceberg --lib delete_file_loadercargo test -p iceberg --lib row_filtercargo test -p iceberg --lib caching_delete_file_loadercargo test -p iceberg --lib delete_file_indexcargo test -p iceberg --libcargo clippy -p iceberg --all-targets --all-features -- -D warningscargo fmt --all -- --checkCloses #3135.