test(transaction): add round-trip tests for transaction APIs against MemoryCatalog - #3133
Open
dhruvarya-db wants to merge 2 commits into
Open
test(transaction): add round-trip tests for transaction APIs against MemoryCatalog#3133dhruvarya-db wants to merge 2 commits into
dhruvarya-db wants to merge 2 commits into
Conversation
…MemoryCatalog Add end-to-end tests that commit transactions against an in-process MemoryCatalog and assert the persisted metadata, covering property updates, location updates, atomic multi-action commits, and rollback when one action in a chained transaction fails.
Drop the module doc and what-style comments to match the terser comment density of the surrounding test modules, keeping only the non-obvious why notes.
blackmwk
requested changes
Sep 2, 2026
blackmwk
left a comment
blackmwk
left a comment
Contributor
There was a problem hiding this comment.
Hi, @dhruvarya-db If you want to add integration tests of transactions against catalogs, you should refer to crates/catalog/loader/tests as example, you could write it against all kinds of catalog. Memory catalog should be used only for ut.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviving #2392, which added these tests but was auto-closed as stale.
Most of the per-action tests in
transaction/mod.rsonly check theActionCommitan action produces. Fast-append is already exercised end-to-end through a catalog (seetest_transaction_snapshot_summaryandtest_fast_append_with_row_lineage), but the property, location, and multi-action paths don't have that kind of round-trip coverage yet. This adds it.Which issue does this PR close?
Part of #1322.
What changes are included in this PR?
A new
test_commit_against_memory_catalogmodule, built on the existingmake_v3_minimal_table_in_cataloghelper, covering:The last two also fold in @andybradshaw's review feedback from #2392 (asserting the chained update is a single commit via the metadata-log length, and adding the failing-transaction case).
Are these changes tested?
They are the tests. Ran them locally with
cargo test -p iceberg; fmt and clippy are clean too.