fix(expr): Fold unary predicate to AlwaysFalse / AlwaysTrue when the field and its ancestors are required - #3125
Open
hsiang-c wants to merge 4 commits into
Open
fix(expr): Fold unary predicate to AlwaysFalse / AlwaysTrue when the field and its ancestors are required#3125hsiang-c wants to merge 4 commits into
AlwaysFalse / AlwaysTrue when the field and its ancestors are required#3125hsiang-c wants to merge 4 commits into
Conversation
hsiang-c
marked this pull request as ready for review
September 1, 2026 23:41
Contributor
Author
|
@CTTY Please take a look for me when you have time, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
is_null/is_not_nullevaluation #3124What changes are included in this PR?
predicate.rs, forIsNullandNotNullunary predicates, fold toAlwaysFalseandAlwaysTruerespectively only when all the field's ancestors arerequired. Otherwise, we might either return nothing or unexpected rows when the projection is pushed down.Are these changes tested?
Yes, unit tests.
AI Disclosure
Yes, I use AI to scaffold most of the test cases and verify the implementation against Iceberg Java.