refactor(sql): derive catalog configuration from properties - #3105
Open
blackmwk wants to merge 2 commits into
Open
refactor(sql): derive catalog configuration from properties#3105blackmwk wants to merge 2 commits into
blackmwk wants to merge 2 commits into
Conversation
blackmwk
force-pushed
the
ir-3099-sql-properties
branch
from
September 4, 2026 03:16
2bda348 to
8b2ba53
Compare
Use the shared property derive for SQL catalog settings while preserving builder precedence, bind-style aliases, schema validation, and forwarded pool properties. Tracks [apache#3099](apache#3099). Generated-by: Codex
blackmwk
force-pushed
the
ir-3099-sql-properties
branch
from
September 4, 2026 03:27
8b2ba53 to
4718d5b
Compare
blackmwk
commented
Sep 4, 2026
blackmwk
marked this pull request as ready for review
September 4, 2026 08:06
Contributor
Author
|
I think this pr is ready for review, cc @CTTY @laskoviymishka |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
SqlCatalogPropertiesderived from the merged property map.Are these changes tested?
cargo test -p iceberg-catalog-sql --lib(51 passed)cargo clippy -p iceberg-catalog-sql --all-targets -- -D warningscargo public-api -p iceberg-catalog-sql --all-features -ss | diff - crates/catalog/sql/public-api.txtcargo fmt --all -- --checkgit diff --checkAI Disclosure
This change was developed with assistance from OpenAI Codex. The contributor reviewed the resulting diff and test output.