refactor(s3tables): derive catalog configuration from properties - #3103
Draft
blackmwk wants to merge 1 commit into
Draft
refactor(s3tables): derive catalog configuration from properties#3103blackmwk wants to merge 1 commit into
blackmwk wants to merge 1 commit into
Conversation
blackmwk
force-pushed
the
ir-3097-s3tables-properties
branch
from
September 4, 2026 03:06
deba379 to
af75761
Compare
Use the shared property derive for S3 Tables settings while retaining builder precedence and downstream AWS properties. Tracks [apache#3097](apache#3097). Generated-by: Codex
blackmwk
force-pushed
the
ir-3097-s3tables-properties
branch
from
September 4, 2026 03:25
af75761 to
9cdbaaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
S3TablesCatalogConfigwith crate-privateS3TablesCatalogPropertiesderived through the sharedPropertiesmacro.S3TablesCatalogBuilder, then resolve them into typed catalog properties with load properties taking precedence.S3TablesCatalog.Are these changes tested?
cargo test -p iceberg-catalog-s3tables --lib(25 passed)cargo clippy -p iceberg-catalog-s3tables --all-targets -- -D warningscargo public-api -p iceberg-catalog-s3tables --all-features -ss | diff - crates/catalog/s3tables/public-api.txtcargo fmt --all -- --checkgit diff --checkAI Disclosure
This change was developed with assistance from OpenAI Codex. The contributor reviewed the resulting diff and test output.