Repository navigation
docs: document Table thread safety - #1094
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wgtmac
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See apache/iceberg#17989 / apache/iceberg#17990 for some context. Iceberg Java contains code that accesses a shared table concurrently from threads with refreshes and commits. That's caused concurrency bugs in the past.
Porting that code over to
iceberg-cppwould be worse. In Java, the JLS defines a data race and so that concurrent pattern is well-defined and indivisible without synchronisation (that's not the case for all types but holds for object references). In C++, such code would be undefined behaviour, so I think it's quite valuable to have at least a comment here stating that, otherwise agents / people might port that code over resulting in UB.