Repository navigation
fix: suppress -Wunused-parameter and -Wshadow warnings under -Wextra - #1081
Merged
Merged
Conversation
Annotate intentionally unused parameters in virtual default implementations with the standard C++ comment convention (/* name */). Files affected: - expression/expression.h - expression/expression_visitor.h - expression/expressions.cc - expression/binder.cc - expression/literal.cc - expression/manifest_evaluator.cc - expression/projections.cc - encryption/key_management_client.h - file_io.h - util/executor_util_internal.h Closes apache#322
zhjwpku
reviewed
Nov 2, 2026
zhjwpku
approved these changes
Nov 2, 2026
zhjwpku
left a comment
zhjwpku
left a comment
Collaborator
There was a problem hiding this comment.
Other than the gitignore issue, LGTM
Reviewer noted build-check/ is a personal local build directory, not a standard pattern. Developers should configure this in their own global gitignore (~/.gitignore_global).
ankitflow001
marked this pull request as draft
November 2, 2026 18:17
ankitflow001
marked this pull request as ready for review
November 2, 2026 18:18
wgtmac
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotate intentionally unused parameters in virtual default implementations with the standard C++ comment convention (/* name */).
Files affected:
Closes #322