Repository navigation
Conversation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: removing the Helm README sections Modes and entry points and Server service identity breaks inbound links from docs/seatunnel.md, docs/vermeer.md and docker/README.md, which now point at rules no page states. The quick start wait loop also closes an interactive shell on timeout.
|
Follow-up review of cf29756 found one remaining shell boundary: the timeout branch now preserves an interactive shell, but |
|
Follow-up fixed in 18942c0: Docker startup failure and readiness timeout return a nonzero status from a subshell, without exiting a normal interactive shell. Each curl probe has a two-second timeout. Success, timeout, startup failure and a hanging socket were simulated locally; Docker itself was not started. |
|
A further documentation check found that |
|
Follow-up fixed in f6ea667: the Helm README now states that |
Review follow-up: restored homepagesReviewed head README follow-up score: 10/10. No remaining actionable findings were identified after correcting the readiness check, version examples, diagram labels, network-policy prerequisites, and HTTP/TLS guidance. Validation included local link and heading checks, shell syntax and simulated readiness success/failure cases, plus Helm lint and template checks. Docker and Kubernetes deployment were not run against a live environment. |
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: relative links, anchors and inbound links into the Helm README resolve at this head, and the build-from-source tarball path matches hugegraph-dist. Both earlier review comments are fixed.
Mirrors hugegraph/hugegraph#370 from the existing source branch. Verification details below are reported by the source PR; See this pull request’s checks for the current ASF CI status.
Summary
docs/README.mdas the canonical repository documentation index and define clear ownership between source docs, module docs, website docs,AGENTS.mdand.serena.helm/hugegraph/docs/README.mdto connect the detailed operations, distribution, RAG, SeaTunnel and Vermeer guides..serenainto three small navigation memories linked to authoritative docs and remove five duplicated/stale memory files.Documentation principles introduced
Validation
Summary by CodeRabbit