Repository navigation
fix(vermeer): replace betweenness path enum with Brandes batches - #375
Merged
imbajin merged 3 commits intoNov 5, 2026
Merged
Conversation
MrJs133
previously approved these changes
Nov 5, 2026
Rebase the completed Brandes batch implementation onto the current master after the final-output lifecycle and preceding Vermeer fixes were merged upstream.
imbajin
force-pushed
the
fix/vermeer-betweenness-brandes-20261105
branch
from
November 5, 2026 17:22
e591917 to
f3c339b
Compare
MrJs133
approved these changes
Nov 5, 2026
imbajin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before → After
Replace stored complete shortest-path lists with unweighted Brandes distances, path counts, predecessors and reverse dependency accumulation. Process sources in synchronized batches and validate completion before output.
Open review and validation boundary
This removes the path-enumeration representation; it does not establish that all OOM or performance problems are solved. Current review flags default max-step failure, inactive-source scatter overhead and full-graph stack allocation, with partition-skew bounds and path-count overflow needing further disposition: 🔗 org Computer #28 review. The PR is submitted for review with these issues unresolved.
The author reports Go 1.23.7 algorithms/worker race tests. No independent tests, multi-worker/skewed-partition run or production-scale benchmark were performed for this submission.
Source: 🔗 org Computer #28.
Visual overview
Design overview of Brandes dependency accumulation and synchronized source batches. Default step-budget, scatter and allocation findings remain open; path-count overflow and partition-skew bounds require further disposition. This does not claim comprehensive OOM, performance, deployment or RC acceptance.