Add support for Compression Dictionary Transport (RFC 9842) - #881
Add support for Compression Dictionary Transport (RFC 9842)#881arturobernalg wants to merge 1 commit into
Conversation
|
@arturobernalg This is a lot of new code. I will scan it for obvious programming errors or inefficiencies. I, however, cannot do a proper review as far as its conformance to the RFC is concerned. I will have to trust you know what you are doing. One question, though. Is there a reason this is an async only feature? |
|
ok2c
left a comment
There was a problem hiding this comment.
@arturobernalg I must admit i do not quite understand what is going on here, but some bits, especially header parsing ones do not good enough to me. I cannot make a call on this change-set
a2ac48c to
c6ac5f3
Compare
Implement dictionary negotiation, storage, matching, and dcb / dcz decoding
c6ac5f3 to
4b4a716
Compare
ok2c
left a comment
There was a problem hiding this comment.
@arturobernalg I have no objections, just one minor comment. This is now your area of responsibility.
Feel free to merge the change-set if you think it is ready or make symmetric changes to the classic transport first. Anyway, there is not much I can do beyond code conceptual sanity checks, parsing improvements, etc.
| return null; | ||
| } | ||
|
|
||
| if (!response.containsHeader(CompressionDictionaryHeaderSupport.USE_AS_DICTIONARY)) { |
There was a problem hiding this comment.
@arturobernalg I presume UseAsDictionary#parse should be smart enough to return null if no dictionary header is present which would make this call unnecessary and overall parsing routine a little more efficient.
Implement dictionary negotiation, storage, matching, and dcb / dcz decoding