[kept for history for now] Move to plain SLF4J - #8320
Draft
rmannibucau wants to merge 4 commits into
Draft
rmannibucau wants to merge 4 commits into
rmannibucau wants to merge 4 commits into
Conversation
…output format - Back LogChannel on SLF4J through a HopLogBuffer log4j2 appender that feeds the in-memory LoggingBuffer and the console (FixedWidthLogLayout). - Replace the old FileWriter mechanics (LogChannelFileWriter, LogChannelFileWriterBuffer, FileLoggingEventListener) with a single HopFileAppender. - Send bare message text to SLF4J and keep the layout-side subject/level/timestamp decoration so UI and console output match the previous slf4j-free format.
Contributor
|
Please create tickets for your PRs so we can keep a trace of changes. The initial review showed some significant issues, I can post the full review tomorrow. |
…event key-values and expose the accurate call-site via the caller boundary
…e hot-path logging cost, and document the design
…th a deque instead of ArrayList.remove(0)
4 tasks
hansva
marked this pull request as draft
September 15, 2026 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall idea is to move to a real logger implementation, there are multiple pitfalls with current manual buffering/filewriter:
edit: issue ref: #8321
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.