Skip to content

HIVE-29878: HMS REST Catalog ignores pagination for listTables and listNamespaces #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aggarwal-Raghav wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −2
Open

HIVE-29878: HMS REST Catalog ignores pagination for listTables and listNamespaces #6750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions ...store/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,17 @@
} else {
namespace = Namespace.empty();
}
return castResponse(ListNamespacesResponse.class, CatalogHandlers.listNamespaces(asNamespaceCatalog, namespace));
String pageToken = PropertyUtil.propertyAsString(vars, "pageToken", null);

Check failure on line 244 in standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogAdapter.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "pageToken" 3 times. 


See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AaBfOxfdlVFYjeMHz18I&open=AaBfOxfdlVFYjeMHz18I&pullRequest=6750
String pageSize = PropertyUtil.propertyAsString(vars, "pageSize", null);

Check failure on line 245 in standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogAdapter.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "pageSize" 3 times. 


See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AaBfOxfdlVFYjeMHz18H&open=AaBfOxfdlVFYjeMHz18H&pullRequest=6750
if (pageSize != null) {
return castResponse(
ListNamespacesResponse.class,
CatalogHandlers.listNamespaces(asNamespaceCatalog, namespace, pageToken, pageSize));
} else {
return castResponse(
ListNamespacesResponse.class,
CatalogHandlers.listNamespaces(asNamespaceCatalog, namespace));
}
}

private CreateNamespaceResponse createNamespace(Object body) {
Expand Down Expand Up @@ -278,7 +288,15 @@

private ListTablesResponse listTables(Map<String, String> vars) {
Namespace namespace = namespaceFromPathVars(vars);
return castResponse(ListTablesResponse.class, CatalogHandlers.listTables(catalog, namespace));
String pageToken = PropertyUtil.propertyAsString(vars, "pageToken", null);
String pageSize = PropertyUtil.propertyAsString(vars, "pageSize", null);
if (pageSize != null) {
return castResponse(
ListTablesResponse.class,
CatalogHandlers.listTables(catalog, namespace, pageToken, pageSize));
} else {
return castResponse(ListTablesResponse.class, CatalogHandlers.listTables(catalog, namespace));
}
}

private LoadTableResponse createTable(Map<String, String> vars, Object body) {
Expand Down
Loading