Hive 29869 beeline size reduce - #6748
Open
illiabarbashov-sketch wants to merge 2 commits into
Open
Conversation
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
|
Aggarwal-Raghav
left a comment
Aggarwal-Raghav
left a comment
Contributor
There was a problem hiding this comment.
Also I can still see the kerby and curator classes in beeline-standalone.jar !! Is this expected?
jar tvf beeline-standalone.jar | grep -i "curator" | head -n 10
0 Fri Feb 01 00:00:00 IST 1980 META-INF/maven/org.apache.curator/
0 Fri Feb 01 00:00:00 IST 1980 META-INF/maven/org.apache.curator/curator-recipes/
68 Fri Feb 01 00:00:00 IST 1980 META-INF/maven/org.apache.curator/curator-recipes/pom.properties
3783 Fri Feb 01 00:00:00 IST 1980 META-INF/maven/org.apache.curator/curator-recipes/pom.xml
0 Fri Feb 01 00:00:00 IST 1980 org/apache/curator/
0 Fri Feb 01 00:00:00 IST 1980 org/apache/curator/framework/
0 Fri Feb 01 00:00:00 IST 1980 org/apache/curator/framework/recipes/
1770 Fri Feb 01 00:00:00 IST 1980 org/apache/curator/framework/recipes/AfterConnectionEstablished$1.class
1817 Fri Feb 01 00:00:00 IST 1980 org/apache/curator/framework/recipes/AfterConnectionEstablished.class
0 Fri Feb 01 00:00:00 IST 1980 org/apache/curator/framework/recipes/atomic/
jar tvf beeline-standalone.jar | grep -i "kerby" | head -n 10
0 Sun Dec 11 19:18:10 IST 2022 org/apache/hadoop/shaded/org/apache/kerby/
0 Sun Dec 11 19:18:10 IST 2022 org/apache/hadoop/shaded/org/apache/kerby/kerberos/
0 Sun Dec 11 19:18:10 IST 2022 org/apache/hadoop/shaded/org/apache/kerby/kerberos/kerb/
2987 Sun Dec 11 19:18:10 IST 2022 org/apache/hadoop/shaded/org/apache/kerby/kerberos/kerb/KrbInputStream.class
1971 Sun Dec 11 19:18:10 IST 2022 org/apache/hadoop/shaded/org/apache/kerby/kerberos/kerb/KrbOutputStream.class
0 Sun Dec 11 19:18:10 IST 2022 org/apache/hadoop/shaded/org/apache/kerby/kerberos/kerb/ccache/
7645 Sun Dec 11 19:18:10 IST 2022 org/apache/hadoop/shaded/org/apache/kerby/kerberos/kerb/ccache/CredCacheInputStream.class
6456 Sun Dec 11 19:18:10 IST 2022 org/apache/hadoop/shaded/org/apache/kerby/kerberos/kerb/ccache/CredCacheOutputStream.class
8287 Sun Dec 11 19:18:10 IST 2022 org/apache/hadoop/shaded/org/apache/kerby/kerberos/kerb/ccache/Credential.class
12508 Sun Dec 11 19:18:10 IST 2022 org/apache/hadoop/shaded/org/apache/kerby/kerberos/kerb/ccache/CredentialCache.class
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.thrift</groupId> |
Contributor
There was a problem hiding this comment.
Why this is excluded? there is direct dependency in beeline module
| </exclusion> | ||
| <exclusion> | ||
| <groupId>org.apache.kerby</groupId> | ||
| <artifactId>kerb-util</artifactId> |
Contributor
There was a problem hiding this comment.
maybe
<exclusion>
<groupId>org.apache.kerby</groupId>
<artifactId>*</artifactId>
</exclusion>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?