HIVE-29865: Fix metastore database filter context returning null DB names - #6744
Open
tanishq-chugh wants to merge 1 commit into
Open
HIVE-29865: Fix metastore database filter context returning null DB names#6744tanishq-chugh wants to merge 1 commit into
tanishq-chugh wants to merge 1 commit into
Conversation
tanishq-chugh
force-pushed
the
hms-db-filter-context
branch
from
September 1, 2026 05:17
22fba73 to
5adbe6e
Compare
tanishq-chugh
changed the title
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
| ret.add(getHivePrivilegeObject(db)); | ||
| } else { | ||
| HivePrivilegeObject hivePrivilegeObject = new HivePrivilegeObject(type, dbName); | ||
| HivePrivilegeObject hivePrivilegeObject = new HivePrivilegeObject(type, catName, dbName, dbName); |
Contributor
There was a problem hiding this comment.
I was able to repro the issue in my setup as well 👍🏻
@tanishq-chugh , 1 question, why objectName i.e 4th paramerter is dbName?
Contributor
There was a problem hiding this comment.
In L90, when DB != null, getHivePrivilegeObject(db) we are setting (type, catlaog, db, null). So in fix I think 4th param should be null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the HivePrivilegeObject constructor being used in DatabaseFilterContext
Why are the changes needed?
To Prevent Null DB Names being returned with HiveMetaStoreAuthorizer filter hook
Does this PR introduce any user-facing change?
Yes, Fixes the NPE in Iceberg REST Catalog and end-user does not encounter Null Db Names when using HiveMetaStoreAuthorizer filter hook
How was this patch tested?
Manual Testing + Added a UT