Skip to content

fix(javascript): use correct typemeta special chars #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaokunyang merged 2 commits into from
Aug 30, 2026
+28 −2
Merged

fix(javascript): use correct typemeta special chars #3995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e503c3
fix(javascript): use correct typemeta special chars
ayush00git Aug 29, 2026
eb67285
fix: refactor comments
ayush00git Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions javascript/packages/core/lib/meta/TypeMeta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ const fieldEncoder = new MetaStringEncoder("$", "_");
const fieldDecoder = new MetaStringDecoder("$", "_");
const pkgEncoder = new MetaStringEncoder(".", "_");
const pkgDecoder = new MetaStringDecoder(".", "_");
const typeNameEncoder = new MetaStringEncoder("$", ".");
const typeNameDecoder = new MetaStringDecoder("$", ".");
const typeNameEncoder = new MetaStringEncoder("$", "_");
const typeNameDecoder = new MetaStringDecoder("$", "_");

const COMPRESS_META_FLAG = 1n << 8n;
const RESERVED_META_FLAGS = 0b111n << 9n;
Expand Down
26 changes: 26 additions & 0 deletions javascript/test/typemeta.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2952,6 +2952,32 @@ describe("typemeta", () => {

expect(result).toBeInstanceOf(EmptyWrapper);
});

// Bytes a spec-conformant peer (for example Java) emits for a named struct
// with namespace "example", typeName "Type_1", and one fixed int32 field
// "v". The type name uses LOWER_UPPER_DIGIT_SPECIAL, where char value 63 is
// "_" per the spec's type-name special-char set ("$", "_").
const specTypeNameMetaBytes = new Uint8Array([
16, 64, 45, 74, 58, 106, 49, 48, 161, 21, 18, 224, 99, 214, 64, 22, 90, 193, 226, 127, 168, 64,
4, 84,
]);

test("decodes spec char value 63 in type names as underscore", () => {
const reader = new BinaryReader({});
reader.reset(specTypeNameMetaBytes);
const decoded = TypeMeta.fromBytes(reader);
expect(decoded.getTypeName()).toBe("Type_1");
});

test("encodes underscore type names with the spec charset", () => {
const meta = TypeMeta.fromTypeInfo(
Type.struct(
{ namespace: "example", typeName: "Type_1" },
{ v: Type.int32({ encoding: "fixed" }) },
),
);
expect(Array.from(meta.toBytes())).toEqual(Array.from(specTypeNameMetaBytes));
});
});

function typeMetaBodyOffset(bytes: Uint8Array) {
Expand Down
Loading