Repository navigation
[common] Fix auto-partition time validation for quarter and invalid dates - #4549
Open
firasbouzazi wants to merge 1 commit into
Open
firasbouzazi wants to merge 1 commit into
firasbouzazi wants to merge 1 commit into
Conversation
…ates Validation of auto-partition time values had two problems: 1. The default QUARTER format "yyyyQ" could never be parsed: the variable-width quarter field cannot follow the adjacent year field, so even the current quarter (e.g. "20244") was rejected. Manually creating a partition or dynamically creating one from the client always failed for QUARTER auto-partitioned tables, and isPastAutoPartition always returned false for them. 2. Parsing used the SMART resolver, which accepts non-existent dates such as "20240230", "20230229" or hour "24", so such partitions could be created on auto-partitioned tables. Parse partition time values with a strict parser that reads a single-letter quarter as a fixed-width field and range-checks it.
firasbouzazi
force-pushed
the
fix-auto-partition-time-validation
branch
from
October 5, 2026 10:10
af80d8b to
f6bf912
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation of auto-partition time values had two problems:
Parse partition time values with a strict parser that reads a single-letter quarter as a fixed-width field and range-checks it.
Purpose
Linked issue: close #4548
Brief change log
Tests
API and Format
Documentation