FINERACT-2692: Fix missing externalId for Groups and Centers#6141
Open
rymghosn wants to merge 2 commits into
Open
FINERACT-2692: Fix missing externalId for Groups and Centers#6141rymghosn wants to merge 2 commits into
rymghosn wants to merge 2 commits into
Conversation
rymghosn
force-pushed
the
port/CBS-762-external-id-missing-groups-centers
branch
from
July 16, 2026 12:59
67b6fb3 to
02714c3
Compare
Add the missing getExternalId() accessor on CenterData, document the externalId field in the Centers/Groups Swagger schemas, and generate a random externalId when one is not supplied on Group/Center creation instead of leaving it blank, consistent with Client creation. Read paths now fall back to a non-null placeholder for any pre-existing blank values. Adds integration test coverage for both the auto-generated and explicitly-supplied externalId cases. Signed-off-by: rym.ghosn <rym.ghosn@foo.mobi>
rymghosn
force-pushed
the
port/CBS-762-external-id-missing-groups-centers
branch
from
July 16, 2026 14:35
02714c3 to
fee4bb9
Compare
Contributor
|
@rymghosn could you please review the failing GitHub Actions? |
…wline) CentersApiResourceSwagger.java was missing a trailing newline, failing :fineract-provider:spotlessJavaCheck in CI. Signed-off-by: rym.ghosn <rym.ghosn@foo.mobi>
rymghosn
force-pushed
the
port/CBS-762-external-id-missing-groups-centers
branch
from
July 17, 2026 12:37
ddd6e93 to
609ddbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups and Centers created without an explicit
externalIdwere left with a blank/null value instead of one being generated, unlike Client creation which already auto-generates one. Separately, theexternalIdfield was missing from theCenterDatadomain model's accessors and from the Swagger schemas for the Centers/Groups APIs, so it wasn't reliably surfaced in responses or generated API docs/clients.This PR (https://issues.apache.org/jira/browse/FINERACT-2692):
Test plan
Added integration test coverage:
CenterIntegrationTest#testCenterCreationWithoutExternalIdGeneratesOne-GroupTest#testGroupCreationWithoutExternalIdGeneratesOneGroupTest#testGroupCreationWithExternalIdIsPersisted