Skip to content

FINERACT-2455: WC - Transaction Type - Accrual and accrual handling#6117

Draft
mariiaKraievska wants to merge 2 commits into
apache:developfrom
openMF:FINERACT-2455/wc-charge-income-accrual-and-accrual-handling
Draft

FINERACT-2455: WC - Transaction Type - Accrual and accrual handling#6117
mariiaKraievska wants to merge 2 commits into
apache:developfrom
openMF:FINERACT-2455/wc-charge-income-accrual-and-accrual-handling

Conversation

@mariiaKraievska

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@mariiaKraievska
mariiaKraievska force-pushed the FINERACT-2455/wc-charge-income-accrual-and-accrual-handling branch from ed6ec41 to 7f2d0c2 Compare July 10, 2026 10:24
@alberto-art3ch
alberto-art3ch force-pushed the FINERACT-2455/wc-charge-income-accrual-and-accrual-handling branch 3 times, most recently from fc0b42b to 081e5dc Compare July 15, 2026 06:00

@galovics galovics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alberto-art3ch
alberto-art3ch force-pushed the FINERACT-2455/wc-charge-income-accrual-and-accrual-handling branch from 293586f to edea87e Compare July 17, 2026 00:27
@alberto-art3ch
alberto-art3ch force-pushed the FINERACT-2455/wc-charge-income-accrual-and-accrual-handling branch from edea87e to e132970 Compare July 17, 2026 05:16
@ruzeynalov
ruzeynalov force-pushed the FINERACT-2455/wc-charge-income-accrual-and-accrual-handling branch from 91e3bbb to 3389ad4 Compare July 17, 2026 12:25
@alberto-art3ch
alberto-art3ch force-pushed the FINERACT-2455/wc-charge-income-accrual-and-accrual-handling branch from 3389ad4 to 9662310 Compare July 17, 2026 14:07
… and expectation fixes after rebase

Restores the QA test layer dropped by the PR rebase (was 293586f):
- TestRailIds C85589-C85603 on all charge accrual scenarios
- scenario hardening: pre-due-date boundary COB, idempotency re-run, closure/repayment/reversal journal entry assertions, re-disbursement re-accrual cycle
- adjustment-after-accrual (submitted-date) and NONE-accounting negative scenarios
- goodwill/allocation expectation fixes for closure accruals (COB runs with business date - 1; closure accruals post after the closing transaction)
- After-hook restoring charge-accrual-date to due-date even when a scenario fails mid-way
@ruzeynalov
ruzeynalov force-pushed the FINERACT-2455/wc-charge-income-accrual-and-accrual-handling branch from 9662310 to 520bf5b Compare July 17, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants