FINERACT-2165: Migrate Schedulerjobhelper internals to typed Feign cl…#6115
Open
elnafateh wants to merge 1 commit into
Open
FINERACT-2165: Migrate Schedulerjobhelper internals to typed Feign cl…#6115elnafateh wants to merge 1 commit into
elnafateh wants to merge 1 commit into
Conversation
elnafateh
force-pushed
the
FINERACT-2165/migrate-schedulerjobhelper
branch
from
July 14, 2026 13:57
5e779fe to
d1a2030
Compare
Contributor
Author
|
Kindly rerun tests |
adamsaghy
reviewed
Jul 16, 2026
| @Operation(summary = "Update a Job", description = "Updates the details of a job.") | ||
| @RequestBody(required = true, content = @Content(schema = @Schema(implementation = SchedulerJobApiResourceSwagger.PutJobsJobIDRequest.class))) | ||
| @ApiResponse(responseCode = "200", description = "OK") | ||
| @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = SchedulerJobApiResourceSwagger.PutJobsJobIDResponse.class))) |
Contributor
There was a problem hiding this comment.
Since we touch this, please rather return CommandProcessingResult directly and we dont need to define any swagger response object...
adamsaghy
reviewed
Jul 16, 2026
| || result.getChanges().containsKey(SchedulerJobApiConstants.cronExpressionParamName))) { | ||
| this.jobRegisterService.rescheduleJob(jobId); | ||
| } | ||
| return this.toApiJsonSerializer.serialize(result); |
Contributor
There was a problem hiding this comment.
Drop the serialization and return CommandProcessingResult directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ient and add PutJobsJobIDResponse schema
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.