Skip to content

FINERACT-2455: Working Capital - Delinquency Reset#6104

Draft
somasorosdpc wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455/working-capital-loan-delinquency-reset
Draft

FINERACT-2455: Working Capital - Delinquency Reset#6104
somasorosdpc wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455/working-capital-loan-delinquency-reset

Conversation

@somasorosdpc

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy

Copy link
Copy Markdown
Contributor
Execution failed for task ':fineract-working-capital-loan:licenseMain'.
> License violations were found: /home/runner/work/fineract/fineract/fineract-working-capital-loan/src/main/resources/db/changelog/tenant/module/workingcapitalloan/parts/0050_delinquency_reset.xml}

@somasorosdpc
somasorosdpc force-pushed the FINERACT-2455/working-capital-loan-delinquency-reset branch from ddb4601 to afed7fd Compare July 14, 2026 13:11

@galovics galovics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0051_delinquency_reset.xml:

<addColumn tableName="m_wc_loan_delinquency_range_schedule">
    <column name="reset" type="BOOLEAN" defaultValue="false"/>
</addColumn>

No <constraints nullable="false"/> here, and defaultValue="false" should be defaultValueBoolean="false" for a BOOLEAN column. The sibling reset column added on m_wc_loan_breach_schedule in 0049_wc_loan_breach_reset.xml did this correctly (defaultValueBoolean="false" + nullable="false") - same column name, same module, same PR author's own prior art. The code compensates with Objects.equals(p.getReset(), true) null-safety wrappers throughout instead of just being able to trust false.

Also: the changeset ids in this file (1783674691355-1, 1784032201725-1) are raw IDE-generated timestamps instead of the module's wcl-00NN-N convention used everywhere else.

WorkingCapitalDelinquencyRescheduleStepDef.java:

log.info("Periods: {}", periods);

Leftover debug log?

@somasorosdpc
somasorosdpc force-pushed the FINERACT-2455/working-capital-loan-delinquency-reset branch from afed7fd to fbf4eda Compare July 17, 2026 08:00
@somasorosdpc
somasorosdpc force-pushed the FINERACT-2455/working-capital-loan-delinquency-reset branch from fbf4eda to b067820 Compare July 17, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants