Skip to content

fix: avoid leaking accessKey/secretKey in RpcException message - #16444

Open
Gitmukeshhh wants to merge 1 commit into
apache:3.3from
Gitmukeshhh:fix/rpcexception-leak-accesskey-secretkey
Open

fix: avoid leaking accessKey/secretKey in RpcException message#16444
Gitmukeshhh wants to merge 1 commit into
apache:3.3from
Gitmukeshhh:fix/rpcexception-leak-accesskey-secretkey

Conversation

@Gitmukeshhh

Copy link
Copy Markdown

AbstractDirectory#list() included the raw registry URL in the exception thrown when the directory was already destroyed. When the registry URL carried MSE Nacos accessKey/secretKey parameters, they were exposed in the exception message. Strip these parameters before building the message.

Fixes #15678

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

AbstractDirectory#list() included the raw registry URL in the
exception thrown when the directory was already destroyed. When the
registry URL carried MSE Nacos accessKey/secretKey parameters, they
were exposed in the exception message. Strip these parameters before
building the message.

Fixes apache#15678
@codecov-commenter

codecov-commenter commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.94%. Comparing base (5553cb7) to head (08886e7).

Files with missing lines Patch % Lines
...dubbo/rpc/cluster/directory/AbstractDirectory.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #16444      +/-   ##
============================================
- Coverage     60.90%   58.94%   -1.96%     
+ Complexity    11765       15   -11750     
============================================
  Files          1953     1953              
  Lines         89271    89272       +1     
  Branches      13473    13473              
============================================
- Hits          54367    52619    -1748     
- Misses        29321    30958    +1637     
- Partials       5583     5695     +112     
Flag Coverage Δ
integration-tests-java21 ?
integration-tests-java8 ?
samples-tests-java21 ?
samples-tests-java8 ?
unit-tests-java11 59.18% <0.00%> (+0.01%) ⬆️
unit-tests-java17 58.64% <0.00%> (-0.01%) ⬇️
unit-tests-java21 58.63% <0.00%> (-0.01%) ⬇️
unit-tests-java25 58.60% <0.00%> (-0.01%) ⬇️
unit-tests-java8 59.18% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] RpcException message should not contain the accessKey and secretKey from MSE Nacos

2 participants