fix: avoid leaking accessKey/secretKey in RpcException message - #16444
Open
Gitmukeshhh wants to merge 1 commit into
Open
fix: avoid leaking accessKey/secretKey in RpcException message#16444Gitmukeshhh wants to merge 1 commit into
Gitmukeshhh wants to merge 1 commit into
Conversation
AbstractDirectory#list() included the raw registry URL in the exception thrown when the directory was already destroyed. When the registry URL carried MSE Nacos accessKey/secretKey parameters, they were exposed in the exception message. Strip these parameters before building the message. Fixes apache#15678
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16444 +/- ##
============================================
- Coverage 60.90% 58.94% -1.96%
+ Complexity 11765 15 -11750
============================================
Files 1953 1953
Lines 89271 89272 +1
Branches 13473 13473
============================================
- Hits 54367 52619 -1748
- Misses 29321 30958 +1637
- Partials 5583 5695 +112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractDirectory#list() included the raw registry URL in the exception thrown when the directory was already destroyed. When the registry URL carried MSE Nacos accessKey/secretKey parameters, they were exposed in the exception message. Strip these parameters before building the message.
Fixes #15678
What is the purpose of the change?
Checklist