fix: wrap CountDownLatch.await() in assertTrue() in tests - #20071
Open
zhang-arvin wants to merge 1 commit into
Open
fix: wrap CountDownLatch.await() in assertTrue() in tests#20071zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
FrankChen021
left a comment
Member
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 1 |
| P2 | 0 |
| P3 | 0 |
| Total | 1 |
Reviewed 4 of 4 changed files.
The review found one test-thread lifecycle issue that can hang the JVM after a timeout.
This is an automated review by Codex GPT-5.6-Luna(max)
| joinCursorThread.start(); | ||
|
|
||
| countDownLatch.await(1, TimeUnit.SECONDS); | ||
| assertTrue(countDownLatch.await(1, TimeUnit.SECONDS)); |
Member
There was a problem hiding this comment.
[P1] Timeout assertion can skip interrupt cleanup
If await returns false, the assertion throws before joinCursorThread.interrupt(). The intentionally infinite, non-daemon test thread can then continue indefinitely and hang the test JVM. Move interruption and joining into cleanup that runs before or alongside the assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Wrap
CountDownLatch.await(timeout, unit)calls inassertTrue()to prevent silent test timeouts. When the boolean return value ofawait()is ignored, a timeout causes the test to silently pass instead of failing.Changes
PostJoinCursorTest.java: wrapcountDownLatch.await(1, TimeUnit.SECONDS)inassertTrue()CoordinatorSegmentMetadataCacheTest.java: wraplatch.await(1, TimeUnit.SECONDS)inAssert.assertTrue()ServerManagerTest.java: wrap 4 occurrences offactory.notifyLatch.await(1000, TimeUnit.MILLISECONDS)inAssert.assertTrue()JettyTest.java: wraplatch.await(5, TimeUnit.SECONDS)inAssert.assertTrue()Closes #9285