feat: druid.s3.enableLegacyMd5 property added - #20055
Open
nozjkoitop wants to merge 3 commits into
Open
Conversation
FrankChen021
left a comment
Member
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 1 |
| P2 | 0 |
| P3 | 0 |
| Total | 1 |
Reviewed 8 of 8 changed files.
Validation: git diff --check cb26014728ab3239bc8d7391f9cf6466e63905b0...HEAD passed. Builds and tests were not run.
This is an automated review by Codex GPT-5.6-Luna(max)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The AWS SDK v2 version used by Druid sends CRC32 request checksums by default for S3 operations such as
DeleteObjects. Some S3-compatible storage implementations do not support these checksum headers and reject requests with a content-hash mismatch, causing operations such as bulk segment kill tasks to failThis PR adds the
druid.s3.enableLegacyMd5configuration property. When enabled, Druid applies the SDK-providedLegacyMd5Pluginto both synchronous and asynchronous S3 clients, restoringContent-MD5request checksumsThe option is disabled by default, leaving the existing behavior unchanged for AWS S3 and compatible storage implementations that support CRC32 checksums
Release note
S3-compatible storage users can set
druid.s3.enableLegacyMd5=trueto use legacy MD5 request checksums. The default remainsfalseKey changed/added classes in this PR
AWSClientConfigS3UtilsServerSideEncryptingAmazonS3This PR has: