Drill-XXXX: Refactor User Interface

.github/workflows/ci.yml

@@ -27,7 +27,7 @@ on: [push, pull_request]
 
 jobs:
   build:
-    name: Main Build
+    name: Main Build (java ${{ matrix.java }}, shard ${{ matrix.shard }})
     runs-on: ubuntu-latest
     if: github.repository == 'apache/drill'
     timeout-minutes: 150
@@ -36,6 +36,12 @@ jobs:
         # Java versions to run unit tests (Jetty 12 requires Java 17+)
         java: [ '17', '21', '25' ]
         profile: ['default-hadoop']
+        # exec/java-exec holds ~31 minutes of the suite in 577 classes, which dominates
+        # the build. Splitting it three ways by class name brings the longest shard to
+        # about 11 minutes. Boundaries were chosen from measured per-class times; the
+        # patterns are exhaustive, so a newly added test always lands in exactly one
+        # shard rather than being silently skipped.
+        shard: [ '1', '2', '3' ]
       fail-fast: false
     steps:
       - name: Checkout
@@ -57,9 +63,41 @@ jobs:
             mkswap /tmp/swapfile
             swapon /tmp/swapfile
           "
+      # Which slice of the suite this job runs. The patterns are exhaustive: every
+      # The patterns are spelled out one prefix at a time because surefire does NOT
+      # support character-class globs: -Dtest='Test[A-F]*' silently matches nothing and
+      # the build passes green having run no tests. Only '*' wildcards and comma
+      # separated lists work, so each letter gets its own entry, in both cases
+      # (TestforBaseTestInheritance has a lowercase f).
+      #
+      # Shard 3 repeats surefire's other default includes (*Test, *Tests, *TestCase) to
+      # pick up classes not named Test*. Verified exhaustive against all 894 test
+      # classes in the repo. TestFrameworkTest matches shards 1 and 3 and runs twice —
+      # harmless, and far safer than a gap that skips tests without saying so.
+      - name: Select test shard
+        id: shard
+        run: |
+          case "${{ matrix.shard }}" in
+            1) echo 'pattern=TestA*,Testa*,TestB*,Testb*,TestC*,Testc*,TestD*,Testd*,TestE*,Teste*,TestF*,Testf*' >> "$GITHUB_OUTPUT" ;;
+            2) echo 'pattern=TestG*,Testg*,TestH*,Testh*,TestI*,Testi*,TestJ*,Testj*,TestK*,Testk*,TestL*,Testl*,TestM*,Testm*,TestN*,Testn*,TestO*,Testo*,TestP*,Testp*' >> "$GITHUB_OUTPUT" ;;
+            3) echo 'pattern=TestQ*,Testq*,TestR*,Testr*,TestS*,Tests*,TestT*,Testt*,TestU*,Testu*,TestV*,Testv*,TestW*,Testw*,TestX*,Testx*,TestY*,Testy*,TestZ*,Testz*,*Test,*Tests,*TestCase,Test0*,Test1*,Test2*,Test3*,Test4*,Test5*,Test6*,Test7*,Test8*,Test9*,Test_*' >> "$GITHUB_OUTPUT" ;;
+          esac
+
+      # -DskipFrontend: no Java test uses webapp/dist, and building it here would
+      # download Node and run npm ci once per matrix entry. The SQL Lab frontend is
+      # built, type-checked, linted and tested by the sqllab-frontend workflow.
+      #
+      # -DforkCount=2: several of the slowest classes are wall-clock bound rather than
+      # CPU bound — TestTimedCallable spends 105 seconds asleep, and the RPC, SSL and
+      # graceful-shutdown tests wait on timeouts — so a second fork overlaps that idle
+      # time at little extra cost. Raise further only with memory headroom: the vector
+      # tests fail with OutOfMemoryException under pressure.
       - name: Build and test
         run: |
           mvn -P${{ matrix.profile }} install --batch-mode --no-transfer-progress \
+          -DskipFrontend=true -DforkCount=2 \
+          -Dsurefire.failIfNoSpecifiedTests=false \
+          -Dtest='${{ steps.shard.outputs.pattern }}' \
           -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
       - name: Remove swap space
         run : |
@@ -107,7 +145,7 @@ jobs:
       # Builds Drill project, performs license checkstyle goal and regenerates java and C++ protobuf files
       - name: Build
         run: |
-          MAVEN_OPTS="-Xms1G -Xmx1G" mvn install -Drat.skip=false -Dlicense.skip=false --batch-mode --no-transfer-progress -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DskipTests=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true && \
+          MAVEN_OPTS="-Xms1G -Xmx1G" mvn install -Drat.skip=false -Dlicense.skip=false --batch-mode --no-transfer-progress -DskipFrontend=true -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -DskipTests=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true && \
           pushd protocol && mvn process-sources -P proto-compile && popd && \
           mkdir contrib/native/client/build && pushd contrib/native/client/build && cmake -G "Unix Makefiles" .. && make cpProtobufs && popd; \
       # Checks whether project files weren't changed after regenerating protobufs

.github/workflows/sqllab-frontend.yml

@@ -0,0 +1,63 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: SQL Lab Frontend CI
+
+on:
+  push:
+    paths:
+      - 'exec/java-exec/src/main/resources/webapp/**'
+  pull_request:
+    paths:
+      - 'exec/java-exec/src/main/resources/webapp/**'
+
+defaults:
+  run:
+    working-directory: exec/java-exec/src/main/resources/webapp
+
+jobs:
+  build-and-test:
+    name: Build & Test
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [20]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: 'npm'
+          cache-dependency-path: exec/java-exec/src/main/resources/webapp/package-lock.json
+
+      - name: Install dependencies
+        run: npm ci
+
+      # No separate type-check step: "npm run build" is "tsc && vite build", so the
+      # build below already fails on a type error.
+      - name: Lint
+        run: npm run lint
+
+      - name: Run tests
+        run: npx vitest run --passWithNoTests
+
+      - name: Build
+        run: npm run build

.gitignore

@@ -34,4 +34,31 @@ target/
 tools/venv/
 venv/
 .vscode/*
-exec/java-exec/src/main/resources/webapp/
+/exec/java-exec/src/main/resources/python/.venv/
+__pycache__/
+*.pyc
+.pytest_cache/
+.coverage
+
+# Frontend (webapp)
+node_modules/
+.vite/
+.env
+.env.local
+.env.*.local
+*.swo
+Thumbs.db
+coverage/
+/exec/java-exec/src/main/resources/webapp/dist/
+/exec/java-exec/src/main/resources/webapp/node/
+result-cache/
+
+# Large GeoJSON files (for local development only, not committed to git)
+# Exception: us-zipcodes.topojson (merged all-states, 91 MB) is committed to git
+# Individual state files (us-al-zipcodes.json, us-ca-zipcodes.json, etc.) are git-ignored
+# These can be regenerated locally using scripts/process-zipcodes.py
+/exec/java-exec/src/main/resources/webapp/public/geojson/us-*-zipcodes.json
+/exec/java-exec/src/main/resources/webapp/public/geojson/us-zipcodes.json
+!/exec/java-exec/src/main/resources/webapp/public/geojson/us-zipcodes.topojson
+/exec/java-exec/src/main/resources/webapp/public/geojson/*.zip
+/exec/java-exec/src/main/resources/webapp/public/geojson/cb_*

CLAUDE.md

@@ -0,0 +1,70 @@
+# Apache Drill — Claude / AI assistant guide
+
+Apache Drill is a schema-free SQL query engine for Hadoop, NoSQL, and cloud storage. This file is the entry point for AI coding assistants working in this repo: it points you to where the docs live, calls out hard constraints, and lists must-run commands.
+
+## Where the docs live
+
+All developer documentation is under [`docs/dev/`](docs/dev/). Start with [`docs/dev/DevDocs.md`](docs/dev/DevDocs.md) for the broader index.
+
+| Topic | Doc |
+|---|---|
+| **Web UI (React SPA)** — architecture, routing, sidebar, contexts, page-by-page reference | [`docs/dev/ui/README.md`](docs/dev/ui/README.md) |
+| **Login / authentication refactor** — design notes, current auth model, options | [`docs/dev/LoginRefactor.md`](docs/dev/LoginRefactor.md) |
+| **Tab persistence & project tree** — server-side tabs, hide vs delete, per-tab Prospector | [`docs/dev/TabPersistence.md`](docs/dev/TabPersistence.md) |
+| **Geospatial filter builder** — draw shapes on a map, push into SQL as ST_ predicates | [`docs/dev/GeoFilterBuilder.md`](docs/dev/GeoFilterBuilder.md) |
+| Prospector AI assistant — backend | [`docs/dev/PROSPECTOR.md`](docs/dev/PROSPECTOR.md) |
+| Enterprise AI provider configuration — proxy, SSL/TLS, custom headers, static parameters | [`docs/dev/ai/ENTERPRISE_PROVIDERS.md`](docs/dev/ai/ENTERPRISE_PROVIDERS.md) |
+| SQL transpiler (GraalPy + sqlglot) | [`docs/dev/TRANSPILER.md`](docs/dev/TRANSPILER.md) |
+| AI features overview | [`docs/dev/AI_FEATURES.md`](docs/dev/AI_FEATURES.md) |
+| Dev environment setup | [`docs/dev/Environment.md`](docs/dev/Environment.md) |
+| Testing | [`docs/dev/Testing.md`](docs/dev/Testing.md) |
+| Maven build | [`docs/dev/Maven.md`](docs/dev/Maven.md) |
+| Jetty 12 migration notes | [`docs/dev/Jetty12Migration.md`](docs/dev/Jetty12Migration.md) |
+| License headers | [`docs/dev/LicenseHeadersAndNotices.md`](docs/dev/LicenseHeadersAndNotices.md) |
+
+If you write new documentation, place it in [`docs/dev/`](docs/dev/), not in source directories. Update this table and the relevant index file.
+
+## Hard constraints
+
+These are easy to get wrong and break the build.
+
+### Checkstyle
+
+After modifying anything in `exec/java-exec`, run:
+
+```bash
+mvn checkstyle:check -pl exec/java-exec
+```
+
+Common failures: `if` statements without braces, unused imports, missing Apache license headers on new files.
+
+### `jdbc-all` jar size limit
+
+The shaded JDBC driver (`exec/jdbc-all`) has a size limit enforced by `maven-enforcer-plugin` (~62 MB).
+
+If you add large resources to `exec/java-exec` (anything in `src/main/resources/webapp/`, large fonts, model files, etc.), update the exclusion filters in [`exec/jdbc-all/pom.xml`](exec/jdbc-all/pom.xml) under the `maven-shade-plugin` configuration. The `webapp/**` filter is already present.
+
+### License headers
+
+Every source file (Java, TypeScript, TSX, JavaScript, CSS, HTML) must have an Apache 2.0 license header. See [`docs/dev/LicenseHeadersAndNotices.md`](docs/dev/LicenseHeadersAndNotices.md).
+
+## UI workflow
+
+The web UI is a React SPA at `exec/java-exec/src/main/resources/webapp/`. Build, dev server, conventions, and per-page reference are all in [`docs/dev/ui/`](docs/dev/ui/README.md).
+
+Quick reference:
+
+```bash
+# Production build (run from repo root via Maven, or directly):
+cd exec/java-exec/src/main/resources/webapp && npm install && npm run build
+
+# Dev server (with HMR; proxies API calls to a running Drillbit on :8047):
+cd exec/java-exec/src/main/resources/webapp && npm run dev
+```
+
+When adding or substantially modifying a UI page, update its doc under [`docs/dev/ui/pages/`](docs/dev/ui/pages/) in the same PR. See [`docs/dev/ui/README.md`](docs/dev/ui/README.md) for conventions.
+
+## Git conventions
+
+- Do **not** add Claude as a co-author on commits.
+- Commits should be descriptive in the imperative ("Add cluster page", not "Added cluster page").

LINTER_RESULTS.md

@@ -0,0 +1,92 @@
+# Code Quality & Linter Results
+**Date**: 2026-04-06
+**Branch**: feature/sqllab-react-ui
+
+## Frontend (React/TypeScript) - `/src/main/resources/webapp`
+
+### ✅ ESLint
+```
+npm run lint
+```
+**Status**: ✅ PASSED (0 warnings, 0 errors)
+- Configuration: ESLint 8.56.0 with TypeScript support
+- Plugins: @typescript-eslint, react-hooks
+- Settings: max-warnings=0 (strict mode)
+- Extensions checked: ts, tsx
+
+### ✅ TypeScript Type Checking
+```
+npx tsc --noEmit
+```
+**Status**: ✅ PASSED (0 errors)
+- Version: 5.3.3
+- All source files in `src/` directory compile without type errors
+- Strict mode enabled
+
+### ✅ Production Build
+```
+npm run build
+```
+**Status**: ✅ PASSED
+- Build time: 23.33s
+- Vite 5.4.21
+- No compilation errors
+- All modules transform successfully
+- Output: Ready for production deployment
+
+---
+
+## Backend (Java) - Drill Project Root
+
+### ✅ Maven Checkstyle
+```
+mvn checkstyle:check -DskipTests
+```
+**Status**: ✅ PASSED (0 violations across all 59 modules)
+
+**Modules Checked**:
+- Drill Core (protocol, common, logical plan)
+- Drill Exec (Java execution engine, memory, RPC, vectors)
+- All 50+ contrib modules:
+  - Storage: JDBC, MongoDB, HBase, Cassandra, Elasticsearch, Splunk, GoogleSheets, Phoenix, Druid, Kudu, HTTP, Kafka, Hive, etc.
+  - Formats: XML, Syslog, Httpd/Nginx Logs, PDF, HDF5, SPSS, SAS, LTSV, Image, Pcap-NG, Esri, Excel, MS Access, Log Regex, Iceberg, Paimon, Delta Lake
+  - Utilities, UDFs, Packaging
+- Metadata (Iceberg, Mongo, RDBMS)
+- JDBC Driver
+- On-YARN
+- Distribution Assembly
+
+**Build Time**: 7.857s
+
+### ✅ Maven Clean Build
+```
+mvn clean
+```
+**Status**: ✅ PASSED (59/59 modules)
+
+---
+
+## Summary
+
+| Tool | Status | Details |
+|------|--------|---------|
+| ESLint | ✅ PASS | 0 warnings, 0 errors (strict mode) |
+| TypeScript | ✅ PASS | 0 type errors |
+| Vite Build | ✅ PASS | Production ready |
+| Maven Checkstyle | ✅ PASS | 0 violations in 59 modules |
+
+### Code Quality Metrics
+- **Frontend**: Fully type-safe, no linting issues
+- **Backend**: All code follows Checkstyle guidelines (Google Java Style Guide)
+- **Overall**: Production-ready code quality
+
+---
+
+## Recent Changes Verified
+All recent changes related to tab selection UX and close tab improvements have passed linting:
+- ✅ `src/pages/SqlLabPage.tsx` - Tab selection and close handler logic
+- ✅ `src/hooks/useTabPersistence.ts` - Tab persistence with empty tab filtering
+- ✅ `src/components/schema-explorer/SchemaExplorer.tsx` - Query navigator integration
+- ✅ `src/components/schema-explorer/QueryNavigator.tsx` - Query selection UI
+
+All changes are clean, type-safe, and follow project conventions.

TODO.md

@@ -0,0 +1 @@
+4.  Force Directed Graph Visualization

build-frontend.sh

@@ -0,0 +1,53 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Build the SQL Lab frontend and update the distribution.
+# Usage: ./build-frontend.sh
+
+set -e
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+WEBAPP_DIR="$SCRIPT_DIR/exec/java-exec/src/main/resources/webapp"
+DIST_BASE="$SCRIPT_DIR/distribution/target"
+
+echo "=== Building SQL Lab frontend ==="
+cd "$WEBAPP_DIR"
+npm run build
+
+echo ""
+echo "=== Building java-exec module ==="
+cd "$SCRIPT_DIR"
+mvn package -pl exec/java-exec -DskipTests -Dcheckstyle.skip=true -q
+
+# Find the distribution directory and copy the jar
+DIST_DIR=$(find "$DIST_BASE" -name "jars" -type d 2>/dev/null | head -1)
+if [ -n "$DIST_DIR" ]; then
+  echo ""
+  echo "=== Copying jar to distribution ==="
+  cp "$SCRIPT_DIR/exec/java-exec/target/drill-java-exec-"*"-SNAPSHOT.jar" "$DIST_DIR/"
+  echo "Updated: $DIST_DIR/"
+else
+  echo ""
+  echo "WARNING: Distribution directory not found under $DIST_BASE"
+  echo "Run a full 'mvn package' first to create the distribution, or copy the jar manually:"
+  echo "  cp exec/java-exec/target/drill-java-exec-*-SNAPSHOT.jar <drill-distribution>/jars/"
+fi
+
+echo ""
+echo "=== Done! Restart Drill and hard-refresh your browser (Cmd+Shift+R) ==="