[feature](compute group) Support show compute groups in non cloud mode (#66697) - #67225
Open
deardeng wants to merge 1 commit into
Open
[feature](compute group) Support show compute groups in non cloud mode (#66697)#67225deardeng wants to merge 1 commit into
deardeng wants to merge 1 commit into
Conversation
apache#66697) pick from apache#66697 Support SHOW CLUSTERS and SHOW COMPUTE GROUPS in non-cloud mode by exposing authorized resource groups and their backend counts.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Member
|
/review |
Contributor
There was a problem hiding this comment.
Review result: approval; no blocking issue found.
Critical checkpoint conclusions:
- Goal and scope: The two-file change is focused and achieves the stated non-cloud behavior for both
SHOW CLUSTERSandSHOW COMPUTE GROUPS: resource-group/location-tag names and backend counts are returned with the intended two-column metadata, while the cloud seven-column path remains unchanged. - Data correctness and authorization: Non-cloud visibility uses the same connection-scoped compute-group membership as query scheduling. Default, single-tag, multi-tag, root/admin all-backend, and invalid-user cases were traced; no extra group exposure, dropped allowed group, or throwing subtype path survived review. Exact same-tag multi-backend counts and deterministic order are covered by the changed unit test.
- Compatibility and result delivery: Both SQL spellings continue through the same parser/builder path, mode-specific title casing and row widths align, and MySQL/Thrift delivery serializes the metadata and rows together. No persistence, FE/BE wire, storage-format, rolling-upgrade, or dynamic-configuration surface is introduced.
- Concurrency, lifecycle, and error handling: Backend membership is read from one immutable registry snapshot. Concurrent tag changes retain the existing administrative observation semantics shared by scheduling; no new lock, lifecycle transition, silent error, or durable inconsistent state was found.
- Tests and coverage: The changed FE test covers cloud and non-cloud metadata, exact counts for multiple backends sharing a tag, deterministic ordering, allowed-tag filtering, and a configured tag with no matching backend. Static mode changes are isolated by per-method setup and Surefire's non-reused test JVMs. No local build or test was run because the authoritative review instructions prohibit builds in this runner.
- Performance and observability: The non-cloud path is one linear backend scan plus sorting by the small set of group names, with no material hot-path, memory, or logging concern.
- User focus: No additional user-provided review focus was supplied.
Round 1 used two complementary full-review lanes and one separate risk-focused lane; all returned NO_NEW_VALUABLE_FINDINGS, and the main agent independently resolved every initial risk item with concrete code evidence.
Contributor
Author
|
@freemandealer - -! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from #66697
Support SHOW CLUSTERS and SHOW COMPUTE GROUPS in non-cloud mode by exposing authorized resource groups and their backend counts.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)