[fix](bdbje) Reuse TLS config for group administration - #67224
Open
Yukang-Lian wants to merge 2 commits into
Open
[fix](bdbje) Reuse TLS config for group administration#67224Yukang-Lian wants to merge 2 commits into
Yukang-Lian wants to merge 2 commits into
Conversation
### What problem does this PR solve? Issue Number: N/A Related PR: selectdb/selectdb-core#10972 Problem Summary: ReplicationGroupAdmin was created with the two-argument constructor, which builds its own default network channel factory instead of using the ReplicationConfig that initialized BDBJE. In a TLS-enabled replication group, administrative operations therefore attempt a plaintext connection. Pass the active RepNetConfig so group administration reuses the configured TLS channel factory. ### Release note BDBJE replication-group administration now uses the configured replication TLS transport. ### Check List (For Author) - Test: Unit Test: ./run-fe-ut.sh --run org.apache.doris.journal.bdbje.BDBEnvironmentTest#testReplicationGroupAdminReusesConfiguredNetworkFactory (1 passed) - Behavior changed: Yes. ReplicationGroupAdmin reuses the active BDBJE network configuration. - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: None
Problem Summary: ReplicationGroupAdmin was created with the two-argument constructor, which builds its own default network channel factory instead of using the ReplicationConfig that initialized BDBJE. In a TLS-enabled replication group, administrative operations therefore attempt a plaintext connection. Pass the active RepNetConfig so group administration reuses the configured TLS channel factory.
Release note
BDBJE replication-group administration now uses the configured replication TLS transport.
Check List (For Author)